[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1335: [NETBEANS-2667] Manage JOptionPane border

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1335: [NETBEANS-2667] Manage JOptionPane border
URL: https://github.com/apache/netbeans/pull/1335#discussion_r298792076
 
 

 ##########
 File path: platform/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java
 ##########
 @@ -15,6 +15,9 @@
  * KIND, either express or implied.  See the License for the
  * specific language governing permissions and limitations
  * under the License.
+ *
+ * Contains a bug fix contributed by Experian. © Experian, 2019. Licensed under Apache 2.0.
 
 Review comment:
   To my understanding: This code is owned by the ASF. The ASF either requires contributions to be to small to create a separate copyright (I'm not sure that I like the term "trivial" for bugfixes) or to be explicitly donated to the ASF. So if you don't add the above line and propose a PR, I would consider it donated to the ASF. It is also small enough to be called a trivial bugfix (it is work, it is appreciated, but it is small). This of course assumes, that you are in a position to donate the code, if you are not, please indicate so.
   TL;DR: For code we don't import from a third party (and thus don't own), ensure that you are the author, you donate the code to the ASF, so please stay with the normal ASF headers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists