You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2007/02/13 19:23:05 UTC
[jira] Resolved: (HTTPCLIENT-631) String constants should be final
[ https://issues.apache.org/jira/browse/HTTPCLIENT-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-631.
------------------------------------------
Resolution: Fixed
Fix Version/s: 3.1 Final
Fixed. Thanks go to Findbugs & Sebastian
Oleg
> String constants should be final
> --------------------------------
>
> Key: HTTPCLIENT-631
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-631
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 3.1 Beta 1
> Reporter: Sebb
> Priority: Minor
> Fix For: 3.1 Final
>
>
> RFC2109Spec - SET_COOKIE_KEY
> RFC2965Spec - SET_COOKIE2_KEY
> both should be final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
Re: [jira] Resolved: (HTTPCLIENT-631) String constants should be final
Posted by sebb <se...@gmail.com>.
On 13/02/07, Oleg Kalnichevski <ol...@apache.org> wrote:
> sebb wrote:
> > On 13/02/07, Oleg Kalnichevski (JIRA) <ji...@apache.org> wrote:
> >>
> >> [
> >> https://issues.apache.org/jira/browse/HTTPCLIENT-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >> ]
> >>
> >> Oleg Kalnichevski resolved HTTPCLIENT-631.
> >> ------------------------------------------
> >>
> >> Resolution: Fixed
> >> Fix Version/s: 3.1 Final
> >>
> >> Fixed. Thanks go to Findbugs & Sebastian
> >>
> >
> > There were some other Findbugs suggestions, but the ones I raised
> > seemed to be the most important so far.
> >
> > Just spotted some more that should probably be fixed - I'll post them
> > later, if that's OK.
> >
>
> Hi Sebastian,
>
> If those problems require just a straightforward fix, just go ahead and
> fix things directly in the SVN trunk. Otherwise, if unsure, please open
> an issue in JIRA
OK, I fixed a few. There were one or two others I thought I saw
earlier, but now cannot find - possibly because of changes since
3.1Beta1. I need to double-check these later.
> > By the way, some of the headers in the 3.1Beta-1 source seem to have
> > the old-style copyright with years in them. These are supposed to be
> > removed.
> >
> > There's a script somewhere in the ASF SVN to do this - I've got a copy
> > somewhere which I used to fix the JMeter code. I can post the link
> > later.
> >
> Please do so.
The script is
update-AL20.pl
in
https://svn.apache.org/repos/private/committers/relicense/src/perl/
but it looks like the files I saw in 3.1b1 have been fixed in trunk.
Could not find any "Copyright 2000" etc anywhere in trunk now.
> Oleg
>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail:
> > httpcomponents-dev-help@jakarta.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
Re: [jira] Resolved: (HTTPCLIENT-631) String constants should be
final
Posted by Oleg Kalnichevski <ol...@apache.org>.
sebb wrote:
> On 13/02/07, Oleg Kalnichevski (JIRA) <ji...@apache.org> wrote:
>>
>> [
>> https://issues.apache.org/jira/browse/HTTPCLIENT-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Oleg Kalnichevski resolved HTTPCLIENT-631.
>> ------------------------------------------
>>
>> Resolution: Fixed
>> Fix Version/s: 3.1 Final
>>
>> Fixed. Thanks go to Findbugs & Sebastian
>>
>
> There were some other Findbugs suggestions, but the ones I raised
> seemed to be the most important so far.
>
> Just spotted some more that should probably be fixed - I'll post them
> later, if that's OK.
>
Hi Sebastian,
If those problems require just a straightforward fix, just go ahead and
fix things directly in the SVN trunk. Otherwise, if unsure, please open
an issue in JIRA
> By the way, some of the headers in the 3.1Beta-1 source seem to have
> the old-style copyright with years in them. These are supposed to be
> removed.
>
> There's a script somewhere in the ASF SVN to do this - I've got a copy
> somewhere which I used to fix the JMeter code. I can post the link
> later.
>
Please do so.
Oleg
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
> httpcomponents-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
Re: [jira] Resolved: (HTTPCLIENT-631) String constants should be final
Posted by sebb <se...@gmail.com>.
On 13/02/07, Oleg Kalnichevski (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/HTTPCLIENT-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Oleg Kalnichevski resolved HTTPCLIENT-631.
> ------------------------------------------
>
> Resolution: Fixed
> Fix Version/s: 3.1 Final
>
> Fixed. Thanks go to Findbugs & Sebastian
>
There were some other Findbugs suggestions, but the ones I raised
seemed to be the most important so far.
Just spotted some more that should probably be fixed - I'll post them
later, if that's OK.
By the way, some of the headers in the 3.1Beta-1 source seem to have
the old-style copyright with years in them. These are supposed to be
removed.
There's a script somewhere in the ASF SVN to do this - I've got a copy
somewhere which I used to fix the JMeter code. I can post the link
later.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org