You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/02/05 04:19:08 UTC
[jira] Created: (RIVER-288) [PATCH] miscellaneous minor fixes - non
crucial
[PATCH] miscellaneous minor fixes - non crucial
-----------------------------------------------
Key: RIVER-288
URL: https://issues.apache.org/jira/browse/RIVER-288
Project: River
Issue Type: Improvement
Reporter: Dave Brosius
Priority: Trivial
Attachments: misc_minor_fixes.patch
just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Peter Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565997#action_12565997 ]
Peter Jones commented on RIVER-288:
-----------------------------------
Re HttpEndpoint, KerberosEndpoint, TcpEndpoint, ProxyTrustInvocationHandler:
Are you referring to the declared types of these fields not being assignable to java.io.Serializable? That is OK, they are not final classes and are expected to have serializable classes as values (as described in the applicable specifications). As Fred said, making these fields transient would be incorrect.
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RIVER-288) [PATCH] miscellaneous minor fixes - non
crucial
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated RIVER-288:
-------------------------------
Attachment: misc_minor_fixes.patch
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Peter Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566024#action_12566024 ]
Peter Jones commented on RIVER-288:
-----------------------------------
Dave,
Instance fields of SocketFactory would not cause a serialization problem. As I said, the assumption is that its subclass-accessible no-arg constructor is retained, with its existing semantics. (Not that I can say what such fields would be for, perhaps related to new constructors...)
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (RIVER-288) [PATCH] miscellaneous minor fixes - non
crucial
Posted by "Tom Hobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Hobbs closed RIVER-288.
---------------------------
Resolution: Fixed
Patch applied. Thanks.
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565798#action_12565798 ]
Fred Oliver commented on RIVER-288:
-----------------------------------
Four of these changes involve marking critical fields transient. I think that, in all of these cases, the contents of the field must be transferred from the server to the client in order for basic functionality to work. Could you explain your motivation for these changes? Have you tested them?
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566020#action_12566020 ]
Dave Brosius commented on RIVER-288:
------------------------------------
Peter,
Sorry for not being clear. I meant that you are banking on the fact that SocketFactory itself (not the derived classes) doesn't have nor will ever have instance fields. Now given that the class is a factory that is probably a safe assumption, albeit not guaranteed by any code contract.
In any case, i have updated the patch file to remove these errors. Again sorry for the mess.
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RIVER-288) [PATCH] miscellaneous minor fixes - non
crucial
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated RIVER-288:
-------------------------------
Attachment: (was: misc_minor_fixes.patch)
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Peter Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566014#action_12566014 ]
Peter Jones commented on RIVER-288:
-----------------------------------
No problem.
> you are banking on a SocketFactory, for instance, not now or ever having
> instance variables, in whatever jvm this code is running on.
Not sure why you say that-- serializable subclasses of SocketFactory can certainly have serializable fields, and fields of their non-serializable superclasses are not serialized. For direct serializable subclasses, the technical requirement is that SocketFactory retains its subclass-accessible no-arg constructor-- which of course would be an incompatible change to remove, so it is a safe assumption.
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566006#action_12566006 ]
Dave Brosius commented on RIVER-288:
------------------------------------
Ok, my apologies then, what this means of course, is that you are banking on a SocketFactory, for instance, not now or ever having instance variables, in whatever jvm this code is running on. But i see that i was incorrect in adding those changes. Again, my apologies for the mistake.
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-288) [PATCH] miscellaneous minor fixes -
non crucial
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565992#action_12565992 ]
Dave Brosius commented on RIVER-288:
------------------------------------
Given that the classes in question aren't serializable, it would seem to me like the correct change. If I am mistaken, my apologies.
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RIVER-288) [PATCH] miscellaneous minor fixes - non
crucial
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated RIVER-288:
-------------------------------
Attachment: misc_minor_fixes.patch
Updated to remove transient items
> [PATCH] miscellaneous minor fixes - non crucial
> -----------------------------------------------
>
> Key: RIVER-288
> URL: https://issues.apache.org/jira/browse/RIVER-288
> Project: River
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: misc_minor_fixes.patch
>
>
> just a hodgepodge of fixes, nothing critical.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.