[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21915: fix: Fix Cypress test broken by extra dashboards

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #21915:
URL: https://github.com/apache/superset/pull/21915#discussion_r1002625453


##########
superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts:
##########
@@ -68,6 +68,20 @@ describe('Charts list', () => {
       cy.createSampleCharts([0]);
     });
 
+    after(() => {
+      cy.visit(DASHBOARD_LIST);
+      cy.wait(1000);
+      toggleBulkSelect();
+      cy.wait(1000);
+      cy.getBySel('table-row').each($row => {
+        if ($row.text().indexOf('Sample dashboard') > -1) {
+          cy.wrap($row).find('input[type="checkbox"]').click();
+        }
+      });
+      cy.getBySel('bulk-select-action').eq(0).contains('Delete').click();
+      confirmDelete();
+    });
+

Review Comment:
   @codyml There is a utils that it seems to do this is `cy.deleteDashboard(id: number, failOnStatusCode: boolean)` or `deleteDashboardByName(dashboardName: string, failOnStatusCode: boolean)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org