[GitHub] [arrow] romainfrancois commented on a change in pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

[GitBox <gi...@apache.org>]

romainfrancois commented on a change in pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#discussion_r553176193



##########
File path: cpp/src/arrow/util/converter.h
##########
@@ -294,6 +302,34 @@ class Chunker {
     return status;
   }
 
+  // we could get bit smarter here since the whole batch of appendable values
+  // will be rejected if a capacity error is raised
+  Status Extend(InputType values, int64_t size) {

Review comment:
       I think adding a `int64_t start` in addition to `size` as in #8650 would help. but I haven't yet reviewed how the chunker code works, e.g. can it "know" that it can handle `n` extra values in the current chunk ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org