[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #904: feat: format gin logger

[GitBox <gi...@apache.org>]

tao12345666333 commented on a change in pull request #904:
URL: https://github.com/apache/apisix-ingress-controller/pull/904#discussion_r820843043



##########
File path: pkg/log/gin_logger.go
##########
@@ -0,0 +1,67 @@
+package log
+
+import (
+	"github.com/gin-gonic/gin"
+	"net"
+	"net/http"
+	"net/http/httputil"
+	"os"
+	"runtime/debug"
+	"strings"
+	"time"

Review comment:
       Please sort them. 
   >Imports are organized in groups, with blank lines between them. The standard library packages are always in the first group.
   

##########
File path: pkg/log/gin_logger.go
##########
@@ -0,0 +1,67 @@
+package log

Review comment:
       We should add Apache LICENSE header. (you can copy from other files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org