[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

[GitBox <gi...@apache.org>]

weizhouapache edited a comment on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-778601783


   > > It seem this does not impact NFS-based environments, as they use script files in scripts/storage/qcow2/ to manage volumes/template/snapshots.
   > > I do not know if there are critical issues with RBD-based environments. maybe @wido @GabrielBrascher know.
   > 
   > NFS is also impacted if you have enabled file locking (which most NFS envs have enabled).
   > 
   
    yes, the scripts in scripts/storage/qcow2/ has been changed to support -U in #4068
   I have tested some actions on vms/volumes/templates on ubuntu 20.04, look ok without this pr.
   
   > RBD isn't impacted in any case as it doesn't use QCOW2.
   
   @wido as far as I know, this impacts RAW format as well.
   `qemu.convert` is used for RBD in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
   `q.convert` in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
   
   maybe there is no issue as in most cases vm is stopped.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org