You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/08/20 00:51:46 UTC
Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Bugs: AURORA-43
https://issues.apache.org/jira/browse/AURORA-43
Repository: aurora
Description
-------
Converting perform_maintenance_hosts into host_drain.
Also, renaming maintenance commands to address AURORA-43.
Diffs
-----
src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
Diff: https://reviews.apache.org/r/24871/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Aug. 22, 2014, 6:39 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 187
> > <https://reviews.apache.org/r/24871/diff/2/?file=666668#file666668line187>
> >
> > If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such)
>
> Maxim Khutornenko wrote:
> I don't see why we should remove it. This is a nice to have feature, which adds flexibility in case someone needs to run a post-drain script. What's pressing the removal?
>
> Joe Smith wrote:
> Keeping the callback here isn't necessary- instead of specifying a callback, the caller of this should just operate on the hosts once this function returns and hosts are drained.
>
> (It was only useful before since it was sandwiched inbetween the drain/end_maintenance, but now the end_maintenance is gone)
Moved the post-drain callback from HostMaintenance into maintenance to keep it as an option post drain operation.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
-----------------------------------------------------------
On Aug. 21, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Joe Smith <ya...@gmail.com>.
> On Aug. 22, 2014, 11:39 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 187
> > <https://reviews.apache.org/r/24871/diff/2/?file=666668#file666668line187>
> >
> > If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such)
>
> Maxim Khutornenko wrote:
> I don't see why we should remove it. This is a nice to have feature, which adds flexibility in case someone needs to run a post-drain script. What's pressing the removal?
Keeping the callback here isn't necessary- instead of specifying a callback, the caller of this should just operate on the hosts once this function returns and hosts are drained.
(It was only useful before since it was sandwiched inbetween the drain/end_maintenance, but now the end_maintenance is gone)
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
-----------------------------------------------------------
On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 4:23 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Aug. 22, 2014, 6:39 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 187
> > <https://reviews.apache.org/r/24871/diff/2/?file=666668#file666668line187>
> >
> > If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such)
I don't see why we should remove it. This is a nice to have feature, which adds flexibility in case someone needs to run a post-drain script. What's pressing the removal?
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
-----------------------------------------------------------
On Aug. 21, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
-----------------------------------------------------------
src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/24871/#comment89470>
If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such)
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/24871/#comment89472>
ack on this- it'd be nice to still have a '1-command-for-all-the-things' but that's aight
- Joe Smith
On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 4:23 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 11:46 p.m.)
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Changes
-------
Adding missing build target.
Bugs: AURORA-43
https://issues.apache.org/jira/browse/AURORA-43
Repository: aurora
Description
-------
Converting perform_maintenance_hosts into host_drain.
Also, renaming maintenance commands to address AURORA-43.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
src/test/python/apache/aurora/admin/BUILD f423e63c125414e3e8a8213f43b24de592e0314a
src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
Diff: https://reviews.apache.org/r/24871/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51319
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On Aug. 22, 2014, 5:26 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 5:26 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51331
-----------------------------------------------------------
Ship it!
Thank you!!
- Joe Smith
On Aug. 22, 2014, 2:26 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 2:26 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 9:26 p.m.)
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Changes
-------
Moved post-drain callback into host_drain command.
Bugs: AURORA-43
https://issues.apache.org/jira/browse/AURORA-43
Repository: aurora
Description
-------
Converting perform_maintenance_hosts into host_drain.
Also, renaming maintenance commands to address AURORA-43.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
Diff: https://reviews.apache.org/r/24871/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/
-----------------------------------------------------------
(Updated Aug. 21, 2014, 11:23 p.m.)
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Changes
-------
Refactoring host_drain for better reuse of options/parsing.
Bugs: AURORA-43
https://issues.apache.org/jira/browse/AURORA-43
Repository: aurora
Description
-------
Converting perform_maintenance_hosts into host_drain.
Also, renaming maintenance commands to address AURORA-43.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab
src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
Diff: https://reviews.apache.org/r/24871/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into
host_drain.
Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51045
-----------------------------------------------------------
Ship it!
Ship It!
- David Robinson
On Aug. 19, 2014, 10:51 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 10:51 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting perform_maintenance_hosts into host_drain.
>
> Also, renaming maintenance commands to address AURORA-43.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1
> src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a
> src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc
> src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a
>
> Diff: https://reviews.apache.org/r/24871/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>