You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2011/10/24 01:30:32 UTC

[jira] [Commented] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

    [ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133778#comment-13133778 ] 

Hudson commented on OGNL-22:
----------------------------

Integrated in ognl #147 (See [https://builds.apache.org/job/ognl/147/])
    Added OGNL-22 in the issue list

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1188002
Files : 
* /commons/proper/ognl/trunk/src/changes/changes.xml

                
> Change the generics signature of ClassCache and ClassCacheImpl.
> ---------------------------------------------------------------
>
>                 Key: OGNL-22
>                 URL: https://issues.apache.org/jira/browse/OGNL-22
>             Project: OGNL
>          Issue Type: Sub-task
>            Reporter: Daniel Pitts
>            Assignee: Maurizio Cucchiara
>
> Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  
> I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.
> The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>
> Changing the get/put methods to take and return "V" type objects.
> Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira