You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:00:42 UTC

[GitHub] [submarine] kevin85421 opened a new pull request #605: SUBMARINE-853. [E2E] Avoid mixing implicit and explicit waits

kevin85421 opened a new pull request #605:
URL: https://github.com/apache/submarine/pull/605


   ### What is this PR for?
   The selenium's official document indicates that
   
   "Do not mix implicit and explicit waits. Doing so can cause unpredictable wait times. For example, setting an implicit wait of 10 seconds and an explicit wait of 15 seconds could cause a timeout to occur after 20 seconds."
   
   Hence, we need to avoid mixing implicit and explicit waits.
   
   https://www.selenium.dev/documentation/en/webdriver/waits/
   
   ### What type of PR is it?
   [Bug Fix | Improvement | Refactoring]
   
   ### Todos
   * Fix testcases ignored by release 5.0
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-853
   
   ### How should this be tested?
   ```
   # Step1: Run Submarine workbench on 127.0.0.1:8080 by operator
   # Step2: Run testcase
   cd submarine-cloud-v2
   
   # Usage: ./hack/run_frontend_e2e.sh ${testcase}
   # Example: 
   ./hack/run_frontend_e2e.sh notebookIT
   ```
   
   ### Screenshots (if appropriate)
   <img width="728" alt="ζˆͺεœ– 2021-06-14 上午2 19 57" src="https://user-images.githubusercontent.com/20109646/121817982-10ed4a00-ccb7-11eb-842f-61edb7c73c27.png">
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #605: SUBMARINE-853. [E2E] Avoid mixing implicit and explicit waits

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #605:
URL: https://github.com/apache/submarine/pull/605


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org