You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by karanjeets <gi...@git.apache.org> on 2015/10/06 12:09:16 UTC
[GitHub] oodt pull request: Added RegEx Exclude Comparator
GitHub user karanjeets opened a pull request:
https://github.com/apache/oodt/pull/33
Added RegEx Exclude Comparator
This Comparator takes Regular Expression and compare it with the absolute path of data file. Returns 0 if match found, else 1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karanjeets/oodt master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/oodt/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit d6d4f075931806fc4647eeb5cfe425c4cda98051
Author: karanjeets <co...@gmail.com>
Date: 2015-10-06T02:04:53Z
Added Regex Exclude Comparator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145820154
Okay, can you please file an OODT jira at issues.apache.org and update CHANGES.txt so we can track it please? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by karanjeets <gi...@git.apache.org>.
Github user karanjeets commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145825717
Hi @buggtb
All done. OODT-885 (https://issues.apache.org/jira/browse/OODT-885) has been raised for the same. Shall I resolve it as well or it will be after merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145922109
Can you give an example of the RegEx which is passed into this Comparator please? e.g. some XML. What do you expect? What would the results be ? Thanks @karanjeets
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by chrismattmann <gi...@git.apache.org>.
Github user chrismattmann commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-147601624
all, I'm going to commit this tonight if there are no objections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145923004
One day we might even ask for unit tests ;)
On 6 Oct 2015 17:38, "Lewis John McGibbney" <no...@github.com>
wrote:
> Can you give an example of the RegEx which is passed into this Comparator
> please? e.g. some XML. What do you expect? What would the results be ?
> Thanks @karanjeets <https://github.com/karanjeets>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/oodt/pull/33#issuecomment-145922109>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by karanjeets <gi...@git.apache.org>.
Github user karanjeets commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145819796
No Tom. This addition is based on a DRAT Issue - https://github.com/chrismattmann/drat/issues/19
Regards,
Karan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by karanjeets <gi...@git.apache.org>.
Github user karanjeets commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145977977
Sure. Here are the details:
* The Comparator expects two arguments - File object and a regular expression (compare item).
* If all the below three conditions are met, then return **0**, else **1**:
* Regular Expression shouldn't be NULL.
* Regular Expression shouldn't be an empty string.
* File's absolute path matches with the regular expression.
**Example**
If we pass the below regular expression, the comparator will return 0 for all the files where its absolute path contains ".svn" and returns 1 otherwise.
```
.*\\.svn.*
```
We are using this Comparator as part of a [DRAT's](https://github.com/chrismattmann/drat) new feature (--exclude) where we exclude processing of all files which contains some regular expression. In short, this feature exclude all files where Comparator returns 0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/oodt/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145848004
As I have no idea what the commit is really about I'll leave the PR closing to Chris or someone else, but that looks much better, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: Added RegEx Exclude Comparator
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on the pull request:
https://github.com/apache/oodt/pull/33#issuecomment-145818678
Hi,
Is there a Jira ticket associated with this addition?
Tom
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---