You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/14 08:27:25 UTC

[jira] [Commented] (KAFKA-3557) Update rocksdb to 4.4.1 and patch updates to snappy and slf4j

    [ https://issues.apache.org/jira/browse/KAFKA-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240689#comment-15240689 ] 

ASF GitHub Bot commented on KAFKA-3557:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1219

    KAFKA-3557; Update rocksdb to 4.4.1 and patch updates to snappy and slf4j

    * The hope is that RocksDb 4.4.1 is more stable than 4.1.0 (occasional segfaults) and 4.2.0 (very frequent segfaults), release notes for 4.4.1: https://www.facebook.com/groups/rocksdb.dev/permalink/925995520832296/
    * slf4j 1.7.21 includes thread-safety fixes: http://www.slf4j.org/news.html
    * snappy 1.1.2.4 includes performance improvements requested by Spark, which apply to our usage: https://github.com/xerial/snappy-java/blob/master/Milestone.md
    
    I ran the stream tests several times and they passed every time while 4.2.0 segfaulted every time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-3557-update-rocks-db-4.4.1-snappy-slf4j

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1219
    
----
commit ab2600a7f2b79c33ac2e2f4e2cae9fe14a0d69b3
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-04-12T21:46:22Z

    Patch version updates for snappy and slf4j

commit 0ea39f76e704db8fe443bee66eb0ebb09d6fe54c
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-04-14T06:19:36Z

    Update RocksDb 4.4.1.

----


> Update rocksdb to 4.4.1 and patch updates to snappy and slf4j
> -------------------------------------------------------------
>
>                 Key: KAFKA-3557
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3557
>             Project: Kafka
>          Issue Type: Bug
>          Components: build
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.10.0.0
>
>
> Adam Retter published RocksDb 4.3.1 and 4.4.1 to Maven after we reported the segfaults we were seeing with 4.2.0 (https://github.com/facebook/rocksdb/issues/1075, KAFKA-3551).
> Snappy and slf4j have patch updates with useful fixes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)