You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2016/01/15 00:54:28 UTC
[VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Hi all,
I have created a build for Apache Calcite 1.6.0, release candidate 0.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
The commit to be voted upon:
http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
The hashes of the artifacts are as follows:
src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1011
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc
Please vote on releasing this package as Apache Calcite 1.6.0.
The vote is open for the next 48 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.6.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Julian
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by James Taylor <ja...@apache.org>.
+1. All tests passing for Phoenix on Calcite.
On Thu, Jan 14, 2016 at 7:39 PM, Julian Hyde <jh...@apache.org> wrote:
> Oops - I got the duration of the vote wrong. I meant to say: “This vote is
> open for the next 96 hours”.
>
> That means 4 days (a day longer than usual because the vote spans a
> weekend). The vote will end at 4pm Pacific on Monday.
>
> Julian
>
>
> > On Jan 14, 2016, at 3:54 PM, Julian Hyde <jh...@apache.org> wrote:
> >
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.6.0, release candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
> >
> > Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
> > src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
> > src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
> > src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1011
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jhyde.asc
> >
> > Please vote on releasing this package as Apache Calcite 1.6.0.
> >
> > The vote is open for the next 48 hours and passes if a majority of
> > at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.6.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Julian
> >
>
>
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Alan Gates <al...@gmail.com>.
+1, ran the unit tests, rat check, checked the signature and the sums.
Alan.
> Julian Hyde <ma...@apache.org>
> January 14, 2016 at 19:39
> Oops - I got the duration of the vote wrong. I meant to say: “This
> vote is open for the next 96 hours”.
>
> That means 4 days (a day longer than usual because the vote spans a
> weekend). The vote will end at 4pm Pacific on Monday.
>
> Julian
>
>
>
> Julian Hyde <ma...@apache.org>
> January 14, 2016 at 15:54
> Hi all,
>
> I have created a build for Apache Calcite 1.6.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release.
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
>
> Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
> src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
> src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
> src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1011
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.6.0.
>
> The vote is open for the next 48 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.6.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Oops - I got the duration of the vote wrong. I meant to say: “This vote is open for the next 96 hours”.
That means 4 days (a day longer than usual because the vote spans a weekend). The vote will end at 4pm Pacific on Monday.
Julian
> On Jan 14, 2016, at 3:54 PM, Julian Hyde <jh...@apache.org> wrote:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.6.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release.
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
>
> Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
> src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
> src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
> src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1011
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.6.0.
>
> The vote is open for the next 48 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.6.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
There’s no way to, in your words, “sneak” a change into a release. I plan to incorporate your PR into branch-1.6, modify the commit that created the release notes, remove the commits created by maven-release-plugin, remove the tag, and start the process on scratch, which means a clean sandbox and “mvn release:prepare”. The property file you refer to is created by release:prepare.
Julian
> On Jan 18, 2016, at 8:56 AM, Vladimir Sitnikov <si...@gmail.com> wrote:
>
> Are you sure mvn release:perform would pick proper commit id?
>
> I think it uses some property file.
>
> Vladimir
Re: [CANCEL] [VOTE] Release apache-calcite-1.6.0 (release candidate
0)
Posted by Josh Elser <jo...@gmail.com>.
Good catch, Vladimir! I just ran into this one myself. I guess I got
lucky previously.
Applied your simple change and it seems to work for me as well.
Julian Hyde wrote:
> Canceling the vote due to https://issues.apache.org/jira/browse/CALCITE-1060<https://issues.apache.org/jira/browse/CALCITE-1060>.
>
> Julian
>
>
[CANCEL] [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Canceling the vote due to https://issues.apache.org/jira/browse/CALCITE-1060 <https://issues.apache.org/jira/browse/CALCITE-1060>.
Julian
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Are you sure mvn release:perform would pick proper commit id?
I think it uses some property file.
Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Julian Hyde <jh...@gmail.com>.
I would commit then do a 'git rebase -i HEAD~10' and re-organize history. I think it's ok - in fact desirable - to clean up the history of a failed RC.
> On Jan 18, 2016, at 3:29 AM, Vladimir Sitnikov <si...@gmail.com> wrote:
>
> Julian,
>
> Can you give a piece of advice what is the best way to "insert commit
> right before mvn release:prepare"?
>
> I used to "kill all the tags, branches, and redo mvn release:clean
> release:prepare". Is there a better/easier way?
>
> Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Here's the PR: https://github.com/apache/calcite/pull/185
Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Julian,
Can you give a piece of advice what is the best way to "insert commit
right before mvn release:prepare"?
I used to "kill all the tags, branches, and redo mvn release:clean
release:prepare". Is there a better/easier way?
Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
I agree with Vladimir, and am inclined to stop the vote and make a new RC with a fix to this bug. As a test issue, it is not “serious”, but it does affect people’s perception of Calcite. And since the fix only affects tests, we will not need to re-do compatibility testing.
Vladimir, Can you provide a pull-request? Or if you prefer, you can commit to branch-1.6.
Julian
> On Jan 18, 2016, at 12:43 AM, Vladimir Sitnikov <si...@gmail.com> wrote:
>
> Adding a dummy `DriverManager.getDrivers();` to
> AlternatingRemoteMetaTest.<clinit> resolves the issue.
>
> static {
> try {
> DriverManager.getDrivers(); // <-- added a line to initialize
> DriverManager class
> DriverManager.registerDriver(new AlternatingDriver());
> } catch (SQLException e) {
> throw new RuntimeException(e);
> }
> }
>
> So the question is if we are fine to ship without such a modification.
> Initially I thought it was not a big issue, however, it turned out to
> reproduce consistently for me, thus I expect it might impact lots of
> users who build Calcite.
>
> Can we sneak DriverManager initialization in 1.6.0?
>
> After the modification, it works fine for me. Tests pass,
> mat-calcite-plugin works.
>
> Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Adding a dummy `DriverManager.getDrivers();` to
AlternatingRemoteMetaTest.<clinit> resolves the issue.
static {
try {
DriverManager.getDrivers(); // <-- added a line to initialize
DriverManager class
DriverManager.registerDriver(new AlternatingDriver());
} catch (SQLException e) {
throw new RuntimeException(e);
}
}
So the question is if we are fine to ship without such a modification.
Initially I thought it was not a big issue, however, it turned out to
reproduce consistently for me, thus I expect it might impact lots of
users who build Calcite.
Can we sneak DriverManager initialization in 1.6.0?
After the modification, it works fine for me. Tests pass,
mat-calcite-plugin works.
Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
How are you able to build Calcite?
I'm testing commit a54c3a85e586a676a61ec3b2e2586512bac8620a
[maven-release-plugin] prepare release calcite-1.6.0.
I use `mvn clean & mvn install`.
It does hang 5 out of 5 times like
https://issues.apache.org/jira/browse/CALCITE-1060
Vladimir
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Josh,
As a committer but not a PMC member[1] your vote is not binding but is considered “advisory”[2]. It is, nevertheless, hugely valued. We welcome votes from all community members.
Julian
[1] https://people.apache.org/committers-by-project.html#calcite
[2] http://www.apache.org/dev/release-publishing.html#voted
> On Jan 15, 2016, at 7:17 PM, Josh Elser <el...@apache.org> wrote:
>
> +1 (binding -- I think?)
>
> * built src tarball
> * built from Git tag
> * xsums/sigs match
> * ran all Maven tests
> * Built and ran some tests with Phoenix QueryServer
> * Glanced over L&N -- nothing looks out of place
> * Gave a read to the release notes (very nice!)
>
> One oddity I noticed during a rat check was the inclusion of a git.properties file. This file contains this curious string "git.commit.id.describe=calcite-1.5.0-101-g3d12a4f-dirty". Everything else in this file seems to match this release.
>
> Thanks for putting this together, Julian!
>
> Julian Hyde wrote:
>> Hi all,
>>
>> I have created a build for Apache Calcite 1.6.0, release candidate 0.
>>
>> Thanks to everyone who has contributed to this release.
>> You can read the release notes here:
>> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
>>
>> The commit to be voted upon:
>> http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
>>
>> Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
>>
>> The artifacts to be voted on are located here:
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
>>
>> The hashes of the artifacts are as follows:
>> src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
>> src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
>> src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
>> src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
>>
>> A staged Maven repository is available for review at:
>> https://repository.apache.org/content/repositories/orgapachecalcite-1011
>>
>> Release artifacts are signed with the following key:
>> https://people.apache.org/keys/committer/jhyde.asc
>>
>> Please vote on releasing this package as Apache Calcite 1.6.0.
>>
>> The vote is open for the next 48 hours and passes if a majority of
>> at least three +1 PMC votes are cast.
>>
>> [ ] +1 Release this package as Apache Calcite 1.6.0
>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>> [ ] -1 Do not release this package because...
>>
>>
>> Here is my vote:
>>
>> +1 (binding)
>>
>> Julian
>>
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Josh Elser <el...@apache.org>.
+1 (binding -- I think?)
* built src tarball
* built from Git tag
* xsums/sigs match
* ran all Maven tests
* Built and ran some tests with Phoenix QueryServer
* Glanced over L&N -- nothing looks out of place
* Gave a read to the release notes (very nice!)
One oddity I noticed during a rat check was the inclusion of a
git.properties file. This file contains this curious string
"git.commit.id.describe=calcite-1.5.0-101-g3d12a4f-dirty". Everything
else in this file seems to match this release.
Thanks for putting this together, Julian!
Julian Hyde wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.6.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release.
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
>
> Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
> src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
> src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
> src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1011
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.6.0.
>
> The vote is open for the next 48 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.6.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
Re: [VOTE] Release apache-calcite-1.6.0 (release candidate 0)
Posted by Pengcheng Xiong <px...@apache.org>.
Hi all,
We have tested 1.6-SNAPSHOT against Hive. Besides minor changes due to
CALCITE-794, all the test cases (over 10k) passed. Thus, here is my vote +1
Release this package as Apache Calcite 1.6.0. Thanks.
Best
Pengcheng
On Thu, Jan 14, 2016 at 3:54 PM, Julian Hyde <jh...@apache.org> wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.6.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release.
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md
>
> The commit to be voted upon:
>
> http://git-wip-us.apache.org/repos/asf/calcite/commit/a54c3a85e586a676a61ec3b2e2586512bac8620a
>
> Its hash is a54c3a85e586a676a61ec3b2e2586512bac8620a.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc0
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 5864e41162320970a86fca6bd4a6a9a8
> src.tar.gz.sha1 b048aaf3c2c480ded96612ed9c418757d632056e
> src.zip.md5 0cdd2f3a663abe6f64e30b881c17409e
> src.zip.sha1 37d31f1359fb550b06157c6a0186901124df6f95
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1011
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.6.0.
>
> The vote is open for the next 48 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.6.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
>