You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/08/12 03:28:56 UTC

[GitHub] [incubator-tuweni] atoulme opened a new pull request #146: make sure to order fields to get the right output in json

atoulme opened a new pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146


   <!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
   <!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
   
   ## PR description
   Master build failed with a flaky test. Fix JSON serialization to get reproducible results.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] atoulme merged pull request #146: make sure to order fields to get the right output in json

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #146: make sure to order fields to get the right output in json

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146#issuecomment-672553811


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=h1) Report
   > Merging [#146](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/276731d49ae77d558f3f5736922a11876d14736c&el=desc) will **increase** coverage by `15.66%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/146/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #146       +/-   ##
   =============================================
   + Coverage     46.66%   62.32%   +15.66%     
   - Complexity      614     4006     +3392     
   =============================================
     Files           162      376      +214     
     Lines          5994    19487    +13493     
     Branches        589     2445     +1856     
   =============================================
   + Hits           2797    12145     +9348     
   - Misses         2944     6048     +3104     
   - Partials        253     1294     +1041     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `62.32% <ø> (?)` | `4006.00 <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/tuweni/ethstats/AuthMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9BdXRoTWVzc2FnZS5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...main/java/org/apache/tuweni/ethstats/NodeInfo.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9Ob2RlSW5mby5qYXZh) | `100.00% <ø> (ø)` | `11.00 <0.00> (ø)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...c/main/kotlin/org/apache/tuweni/hobbits/Relayer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-aG9iYml0cy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvaG9iYml0cy9SZWxheWVyLmt0) | `0.00% <0.00%> (-96.43%)` | `0.00% <0.00%> (-8.00%)` | |
   | ... and [373 more](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=footer). Last update [276731d...10a5a9b](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #146: make sure to order fields to get the right output in json

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146#issuecomment-672553811


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=h1) Report
   > Merging [#146](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/276731d49ae77d558f3f5736922a11876d14736c&el=desc) will **increase** coverage by `15.66%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/146/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #146       +/-   ##
   =============================================
   + Coverage     46.66%   62.32%   +15.66%     
   - Complexity      614     4006     +3392     
   =============================================
     Files           162      376      +214     
     Lines          5994    19487    +13493     
     Branches        589     2445     +1856     
   =============================================
   + Hits           2797    12145     +9348     
   - Misses         2944     6048     +3104     
   - Partials        253     1294     +1041     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `62.32% <ø> (?)` | `4006.00 <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/tuweni/ethstats/AuthMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9BdXRoTWVzc2FnZS5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...main/java/org/apache/tuweni/ethstats/NodeInfo.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9Ob2RlSW5mby5qYXZh) | `100.00% <ø> (ø)` | `11.00 <0.00> (ø)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...c/main/kotlin/org/apache/tuweni/hobbits/Relayer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-aG9iYml0cy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvaG9iYml0cy9SZWxheWVyLmt0) | `0.00% <0.00%> (-96.43%)` | `0.00% <0.00%> (-8.00%)` | |
   | ... and [373 more](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=footer). Last update [276731d...0e794ad](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #146: make sure to order fields to get the right output in json

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146#issuecomment-672553811


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=h1) Report
   > Merging [#146](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/276731d49ae77d558f3f5736922a11876d14736c&el=desc) will **increase** coverage by `15.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/146/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #146       +/-   ##
   =============================================
   + Coverage     46.66%   62.31%   +15.65%     
   - Complexity      614     4005     +3391     
   =============================================
     Files           162      376      +214     
     Lines          5994    19487    +13493     
     Branches        589     2445     +1856     
   =============================================
   + Hits           2797    12143     +9346     
   - Misses         2944     6048     +3104     
   - Partials        253     1296     +1043     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `62.31% <ø> (?)` | `4005.00 <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/tuweni/ethstats/AuthMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9BdXRoTWVzc2FnZS5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...main/java/org/apache/tuweni/ethstats/NodeInfo.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9Ob2RlSW5mby5qYXZh) | `100.00% <ø> (ø)` | `11.00 <0.00> (ø)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...c/main/kotlin/org/apache/tuweni/hobbits/Relayer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-aG9iYml0cy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvaG9iYml0cy9SZWxheWVyLmt0) | `0.00% <0.00%> (-96.43%)` | `0.00% <0.00%> (-8.00%)` | |
   | ... and [373 more](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=footer). Last update [276731d...f2f526f](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #146: make sure to order fields to get the right output in json

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146#issuecomment-672553811


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=h1) Report
   > Merging [#146](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/276731d49ae77d558f3f5736922a11876d14736c&el=desc) will **increase** coverage by `20.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/146/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #146       +/-   ##
   =============================================
   + Coverage     46.66%   66.93%   +20.26%     
   - Complexity      614     4293     +3679     
   =============================================
     Files           162      401      +239     
     Lines          5994    19867    +13873     
     Branches        589     2450     +1861     
   =============================================
   + Hits           2797    13297    +10500     
   - Misses         2944     5177     +2233     
   - Partials        253     1393     +1140     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `45.12% <ø> (-1.54%)` | `595.00 <ø> (-19.00)` | |
   | #unit | `62.32% <ø> (?)` | `4005.00 <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/tuweni/ethstats/AuthMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9BdXRoTWVzc2FnZS5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...main/java/org/apache/tuweni/ethstats/NodeInfo.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9Ob2RlSW5mby5qYXZh) | `100.00% <ø> (ø)` | `11.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/eth/Status.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9TdGF0dXMua3Q=) | `0.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...n/kotlin/org/apache/tuweni/devp2p/eth/EthClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhDbGllbnQua3Q=) | `0.00% <0.00%> (-6.42%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...a/org/apache/tuweni/config/EmptyConfiguration.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL0VtcHR5Q29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...main/kotlin/org/apache/tuweni/les/StatusMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-bGVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9sZXMvU3RhdHVzTWVzc2FnZS5rdA==) | `93.25% <0.00%> (ø)` | `17.00% <0.00%> (?%)` | |
   | [...g/apache/tuweni/toml/TomlInvalidTypeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-dG9tbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3RvbWwvVG9tbEludmFsaWRUeXBlRXhjZXB0aW9uLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
   | [...main/java/org/apache/tuweni/toml/ArrayVisitor.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-dG9tbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3RvbWwvQXJyYXlWaXNpdG9yLmphdmE=) | `78.57% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
   | [...n/java/org/apache/tuweni/progpow/KISS99Random.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cG93L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvcHJvZ3Bvdy9LSVNTOTlSYW5kb20uamF2YQ==) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
   | [...kotlin/org/apache/tuweni/les/GetReceiptsMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-bGVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9sZXMvR2V0UmVjZWlwdHNNZXNzYWdlLmt0) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
   | ... and [322 more](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=footer). Last update [276731d...0e794ad](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #146: make sure to order fields to get the right output in json

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #146:
URL: https://github.com/apache/incubator-tuweni/pull/146#issuecomment-672553811


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=h1) Report
   > Merging [#146](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/276731d49ae77d558f3f5736922a11876d14736c&el=desc) will **increase** coverage by `15.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/146/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #146       +/-   ##
   =============================================
   + Coverage     46.66%   62.31%   +15.65%     
   - Complexity      614     4005     +3391     
   =============================================
     Files           162      376      +214     
     Lines          5994    19487    +13493     
     Branches        589     2445     +1856     
   =============================================
   + Hits           2797    12143     +9346     
   - Misses         2944     6048     +3104     
   - Partials        253     1296     +1043     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `62.31% <ø> (?)` | `4005.00 <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/tuweni/ethstats/AuthMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9BdXRoTWVzc2FnZS5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...main/java/org/apache/tuweni/ethstats/NodeInfo.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9Ob2RlSW5mby5qYXZh) | `100.00% <ø> (ø)` | `11.00 <0.00> (ø)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...c/main/kotlin/org/apache/tuweni/hobbits/Relayer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree#diff-aG9iYml0cy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvaG9iYml0cy9SZWxheWVyLmt0) | `0.00% <0.00%> (-96.43%)` | `0.00% <0.00%> (-8.00%)` | |
   | ... and [373 more](https://codecov.io/gh/apache/incubator-tuweni/pull/146/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=footer). Last update [276731d...10a5a9b](https://codecov.io/gh/apache/incubator-tuweni/pull/146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org