[jira] [Work logged] (BEAM-6231) Triage test failures introduced by use_executable_stage_bundle_execution

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-6231?focusedWorklogId=180418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180418 ]

ASF GitHub Bot logged work on BEAM-6231:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jan/19 21:43
            Start Date: 02/Jan/19 21:43
    Worklog Time Spent: 10m 
      Work Description: HuangLED commented on pull request #7356: [BEAM-6231] Make Dataflow runner harness work with FixedWindow
URL: https://github.com/apache/beam/pull/7356#discussion_r244863449
 
 

 ##########
 File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java
 ##########
 @@ -191,6 +195,37 @@ public Node apply(MutableNetwork<Node, Edge> input) {
         Iterables.filter(input.nodes(), InstructionOutputNode.class)) {
       InstructionOutput instructionOutput = node.getInstructionOutput();
 
+      // If this is the input PCollection or the output PCollection for an ExecutableStage, it's
+      // necessary to check whether the window coder is not a GlobalWindow coder.
+      if (isExecutableStageInputPCollection(input, node)
+          || isExecutableStageOutputPCollection(input, node)) {
 
 Review comment:
   for education purpose, what are the pcollection types beyond Input and output?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 180418)
    Time Spent: 3h 50m  (was: 3h 40m)

> Triage test failures introduced by use_executable_stage_bundle_execution
> ------------------------------------------------------------------------
>
>                 Key: BEAM-6231
>                 URL: https://issues.apache.org/jira/browse/BEAM-6231
>             Project: Beam
>          Issue Type: Test
>          Components: runner-dataflow
>            Reporter: Boyuan Zhang
>            Assignee: Boyuan Zhang
>            Priority: Major
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)