You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/17 10:27:47 UTC
Review Request 34326: Need to be able to create customized graphs
based on YARN queue-specific metrics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34326/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-11195
https://issues.apache.org/jira/browse/AMBARI-11195
Repository: ambari
Description
-------
This patch substitues the regexp in all the queue specific metric name (both AMS and JMX type metrics) with the actual names of all the existing queues. Thus on metric selection combobox valid queue specific metric names appears.
Diffs
-----
ambari-web/app/assets/test/tests.js 64456a9
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 10c49db
ambari-web/test/controllers/main/service/widgets/create/wizard_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/34326/diff/
Testing
-------
# Tested that the patch works on a cluster with following hierarchical queues:
root
/ \
default test1
/ \
test2 test3
# Added a unit test with a hierarchical queues scenario
# Verified that all existing unit tests passes
Thanks,
Jaimin Jetly
Re: Review Request 34326: Need to be able to create customized graphs
based on YARN queue-specific metrics
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34326/#review84063
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On May 17, 2015, 9:37 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34326/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 9:37 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11195
> https://issues.apache.org/jira/browse/AMBARI-11195
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patch substitues the regexp in all the queue specific metric name (both AMS and JMX type metrics) with the actual names of all the existing queues. Thus on metric selection combobox valid queue specific metric names appears.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 64456a9
> ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 9c48872
> ambari-web/app/controllers/main/service/widgets/create/step3_controller.js f946b74
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 10c49db
> ambari-web/test/controllers/main/service/widgets/create/wizard_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34326/diff/
>
>
> Testing
> -------
>
> # Tested that the patch works on a cluster with following hierarchical queues (all the metrics for all queues can be selected and queue related widgets can be successfully created):
> root
> / \
> default test1
> / \
> test2 test3
>
> # Added a unit test with a hierarchical queues scenario
>
> # Verified that all existing unit tests passes
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 34326: Need to be able to create customized graphs
based on YARN queue-specific metrics
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34326/
-----------------------------------------------------------
(Updated May 17, 2015, 9:37 a.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-11195
https://issues.apache.org/jira/browse/AMBARI-11195
Repository: ambari
Description
-------
This patch substitues the regexp in all the queue specific metric name (both AMS and JMX type metrics) with the actual names of all the existing queues. Thus on metric selection combobox valid queue specific metric names appears.
Diffs
-----
ambari-web/app/assets/test/tests.js 64456a9
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 9c48872
ambari-web/app/controllers/main/service/widgets/create/step3_controller.js f946b74
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 10c49db
ambari-web/test/controllers/main/service/widgets/create/wizard_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/34326/diff/
Testing (updated)
-------
# Tested that the patch works on a cluster with following hierarchical queues (all the metrics for all queues can be selected and queue related widgets can be successfully created):
root
/ \
default test1
/ \
test2 test3
# Added a unit test with a hierarchical queues scenario
# Verified that all existing unit tests passes
Thanks,
Jaimin Jetly
Re: Review Request 34326: Need to be able to create customized graphs
based on YARN queue-specific metrics
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34326/
-----------------------------------------------------------
(Updated May 17, 2015, 9:35 a.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-11195
https://issues.apache.org/jira/browse/AMBARI-11195
Repository: ambari
Description
-------
This patch substitues the regexp in all the queue specific metric name (both AMS and JMX type metrics) with the actual names of all the existing queues. Thus on metric selection combobox valid queue specific metric names appears.
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js 64456a9
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 9c48872
ambari-web/app/controllers/main/service/widgets/create/step3_controller.js f946b74
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 10c49db
ambari-web/test/controllers/main/service/widgets/create/wizard_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/34326/diff/
Testing
-------
# Tested that the patch works on a cluster with following hierarchical queues:
root
/ \
default test1
/ \
test2 test3
# Added a unit test with a hierarchical queues scenario
# Verified that all existing unit tests passes
Thanks,
Jaimin Jetly