[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #1674: feat: add join type for logical plan display

[GitBox <gi...@apache.org>]

Jimexist commented on a change in pull request #1674:
URL: https://github.com/apache/arrow-datafusion/pull/1674#discussion_r791901201



##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -934,16 +934,30 @@ impl LogicalPlan {
                     LogicalPlan::Join(Join {
                         on: ref keys,
                         join_constraint,
+                        join_type,
                         ..
                     }) => {
                         let join_expr: Vec<String> =
                             keys.iter().map(|(l, r)| format!("{} = {}", l, r)).collect();
+                        let join_type = match join_type {

Review comment:
       Can this just be a display call?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org