You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/06/24 21:59:28 UTC
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17634
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
IMPALA-10768: Deflake CatalogHmsFileMetadataTest
This test fails intermittently with an error which seems
to suggest that 2 lists which are being compared are in
different order. This patch sorts the two lists of
filedescriptors to make the comparision more deterministic.
Testing:
Ran the test locally a few times.
Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
---
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/17634/1
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/9003/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 23:55:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7268/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 17:28:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 23:36:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
IMPALA-10768: Deflake CatalogHmsFileMetadataTest
This test fails intermittently with an error which seems
to suggest that 2 lists which are being compared are in
different order. This patch sorts the two lists of
filedescriptors to make the comparision more deterministic.
Testing:
Ran the test locally a few times.
Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
---
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/17634/2
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
Patch Set 2: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 22:39:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
IMPALA-10768: Deflake CatalogHmsFileMetadataTest
This test fails intermittently with an error which seems
to suggest that 2 lists which are being compared are in
different order. This patch sorts the two lists of
filedescriptors to make the comparision more deterministic.
Testing:
Ran the test locally a few times.
Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Reviewed-on: http://gerrit.cloudera.org:8080/17634
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/9002/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 23:55:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 )
Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0909f2364b4bc19d2a8786d2b99c9289e13b4ee
Gerrit-Change-Number: 17634
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 17:28:33 +0000
Gerrit-HasComments: No