You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/08 17:35:14 UTC
[GitHub] [flink] stevenzwu opened a new pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
stevenzwu opened a new pull request #14595:
URL: https://github.com/apache/flink/pull/14595
…ient() public
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
sjwiesman edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758674412
I agree with @dawidwys that this method was made internal on purpose. The only reason it isn't private is to share functionality with the deprecated methods in DataStreamUtils. Ideally, I would like to keep it that way if `executeAndCollect` works for you.
If not, then I think `ClientAndIterator` needs to be updated before being made public. Proper `getters`, updated javadoc, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851",
"triggerID" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851",
"triggerID" : "758669909",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2ea6c0e3252fd148d787cf107d94aead290a5ca8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c2dca230b89f930943dcafbda01f6cd6e5b88c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835)
* 2ea6c0e3252fd148d787cf107d94aead290a5ca8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu closed pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu closed pull request #14595:
URL: https://github.com/apache/flink/pull/14595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758836805
I'll will update the javadoc to be more clear :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34d88a71b61f62f2775a41eb291c017c6d76b8ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756898783
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 34d88a71b61f62f2775a41eb291c017c6d76b8ab (Fri Jan 08 17:36:53 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20871).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 34d88a71b61f62f2775a41eb291c017c6d76b8ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34d88a71b61f62f2775a41eb291c017c6d76b8ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825)
* 31c2dca230b89f930943dcafbda01f6cd6e5b88c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-757065274
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-757566603
Regarding the whitespace format change, I have run `mvn com.diffplug.spotless:spotless-maven-plugin:apply` to verify
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c2dca230b89f930943dcafbda01f6cd6e5b88c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851",
"triggerID" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c2dca230b89f930943dcafbda01f6cd6e5b88c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835)
* 2ea6c0e3252fd148d787cf107d94aead290a5ca8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758471371
Hi @stevenzwu ,
What is the exact motivation for the change? Is it only to be able to cancel the job after a certain number of elements? If so as far as I can tell from the code, closing the iterator from `CloseableIterator<T> executeAndCollect(String jobExecutionName)` will do the trick.
Anyway, if you feel we need access to the `JobClient` I think we should fix the `ClientAndIterator` class before making it publicly accessible. Right now it is marked `Internal`. Personally I am also not the biggest fan of accessing fields directly instead of via getters. That should not be a bigger problem in an `Internal` class, but might be problematic in a public one.
@sjwiesman WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758870877
@sjwiesman thx. I should have looked into the iterator code first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758674412
I agree with @dawidwys that this method was made internal on purpose. The only reason it isn't private is to share functionality with the deprecated methods in DataStreamUtils. Ideally, I would like to keep it that way if `executeAndCollect` works for you.
If not, then I think `ClientAndIterator` needs to be updated before being made public. Proper `getters` and updated javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-778692513
@davidwys @sjwiesman I'd like to reopen this request. Now the additional requirement is to retrieve `JobID` to trigger jobmanager failover. e.g.
https://github.com/apache/flink/blob/91cc3082c23b38513250d78bbb385271bd223df3/flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/src/FileSourceTextLinesITCase.java#L136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34d88a71b61f62f2775a41eb291c017c6d76b8ab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-757065274
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] stevenzwu commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758765285
@davidwys yes, the motivation is to be able to cancel the job after a certain number of elements. I didn't realize that closing the iterator from CloseableIterator<T> can cancel the job as well. Will close this PR and jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34d88a71b61f62f2775a41eb291c017c6d76b8ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825)
* 31c2dca230b89f930943dcafbda01f6cd6e5b88c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851",
"triggerID" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ea6c0e3252fd148d787cf107d94aead290a5ca8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-758669909
BTW if you want to retrigger the azure build you can add a comment to the PR: `@flinkbot run azure`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "757065274",
"triggerType" : "MANUAL"
}, {
"hash" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11835",
"triggerID" : "31c2dca230b89f930943dcafbda01f6cd6e5b88c",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851",
"triggerID" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"triggerType" : "PUSH"
}, {
"hash" : "2ea6c0e3252fd148d787cf107d94aead290a5ca8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "758669909",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2ea6c0e3252fd148d787cf107d94aead290a5ca8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756898783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14595: [FLINK-20871][API/DataStream] Make DataStream#executeAndCollectWithCl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14595:
URL: https://github.com/apache/flink/pull/14595#issuecomment-756911772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
}, {
"hash" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825",
"triggerID" : "34d88a71b61f62f2775a41eb291c017c6d76b8ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34d88a71b61f62f2775a41eb291c017c6d76b8ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11710) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org