You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/10/12 23:12:40 UTC
[GitHub] [fineract] hmg65 opened a new pull request, #2660: FINERACT-1719: Introduce Lombok to mix module
hmg65 opened a new pull request, #2660:
URL: https://github.com/apache/fineract/pull/2660
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2660: FINERACT-1719: Introduce Lombok to mix module
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2660:
URL: https://github.com/apache/fineract/pull/2660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2660: FINERACT-1719: Introduce Lombok to mix module
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2660:
URL: https://github.com/apache/fineract/pull/2660#discussion_r994345378
##########
fineract-provider/src/main/java/org/apache/fineract/mix/service/XBRLBuilder.java:
##########
@@ -145,7 +145,7 @@ Element addTaxonomy(final Element rootElement, final MixTaxonomyData taxonomy, f
}
private String getUnitRef(final MixTaxonomyData tx) {
- return tx.isPortfolio() ? UNITID_PURE : UNITID_CUR;
+ return tx.getType() == 5 ? UNITID_PURE : UNITID_CUR;
Review Comment:
Let's revert this line.
##########
fineract-provider/src/main/java/org/apache/fineract/mix/data/MixTaxonomyData.java:
##########
@@ -26,42 +33,11 @@ public class MixTaxonomyData {
public static final Integer EXPENSE = 3;
@SuppressWarnings("unused")
- private final Long id;
- private final String name;
- private final String namespace;
- private final String dimension;
- private final Integer type;
+ private Long id;
+ private String name;
+ private String namespace;
+ private String dimension;
+ private Integer type;
@SuppressWarnings("unused")
- private final String description;
-
- public MixTaxonomyData(final Long id, final String name, final String namespace, final String dimension, final Integer type,
- final String description) {
-
- this.id = id;
- this.name = name;
- this.namespace = namespace;
- this.dimension = dimension;
- this.type = type;
- this.description = description;
- }
-
- public String getName() {
- return this.name;
- }
-
- public String getNamespace() {
- return this.namespace;
- }
-
- public String getDimension() {
- return this.dimension;
- }
-
- public Integer getType() {
- return this.type;
- }
-
- public boolean isPortfolio() {
Review Comment:
Why remove this?
##########
fineract-provider/src/main/java/org/apache/fineract/mix/data/ContextData.java:
##########
@@ -18,29 +18,18 @@
*/
package org.apache.fineract.mix.data;
-public class ContextData {
-
- private final String dimensionType;
- private final String dimension;
- private final Integer periodType;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+import lombok.experimental.Accessors;
- public ContextData(final String dimensionType, final String dimension, final Integer taxonomyType) {
- this.dimensionType = dimensionType;
- this.dimension = dimension;
- this.periodType = taxonomyType.equals(MixTaxonomyData.BALANCESHEET) || taxonomyType.equals(MixTaxonomyData.PORTFOLIO) ? 0 : 1;
Review Comment:
This logic is missing where the object gets instantiated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 commented on a diff in pull request #2660: FINERACT-1719: Introduce Lombok to mix module
Posted by GitBox <gi...@apache.org>.
hmg65 commented on code in PR #2660:
URL: https://github.com/apache/fineract/pull/2660#discussion_r995115169
##########
fineract-provider/src/main/java/org/apache/fineract/mix/data/ContextData.java:
##########
@@ -18,29 +18,18 @@
*/
package org.apache.fineract.mix.data;
-public class ContextData {
-
- private final String dimensionType;
- private final String dimension;
- private final Integer periodType;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+import lombok.experimental.Accessors;
- public ContextData(final String dimensionType, final String dimension, final Integer taxonomyType) {
- this.dimensionType = dimensionType;
- this.dimension = dimension;
- this.periodType = taxonomyType.equals(MixTaxonomyData.BALANCESHEET) || taxonomyType.equals(MixTaxonomyData.PORTFOLIO) ? 0 : 1;
Review Comment:
corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 commented on a diff in pull request #2660: FINERACT-1719: Introduce Lombok to mix module
Posted by GitBox <gi...@apache.org>.
hmg65 commented on code in PR #2660:
URL: https://github.com/apache/fineract/pull/2660#discussion_r995114590
##########
fineract-provider/src/main/java/org/apache/fineract/mix/service/XBRLBuilder.java:
##########
@@ -145,7 +145,7 @@ Element addTaxonomy(final Element rootElement, final MixTaxonomyData taxonomy, f
}
private String getUnitRef(final MixTaxonomyData tx) {
- return tx.isPortfolio() ? UNITID_PURE : UNITID_CUR;
+ return tx.getType() == 5 ? UNITID_PURE : UNITID_CUR;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org