[jira] [Commented] (PHOENIX-5390) Cleanup anonymous inner classes in phoenix-core/main

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894256#comment-16894256 ] 

Hadoop QA commented on PHOENIX-5390:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12976016/PHOENIX-5390-Cleanup-anonymous-classes.patch
  against master branch at commit 665e224e4d9a0e991e38083b983ec38989dfd5e7.
  ATTACHMENT ID: 12976016

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        private CorrelateResultIterator(ParallelScanGrouper scanGrouper, Scan scan) throws SQLException {
+                    throw new SQLExceptionInfo.Builder(SQLExceptionCode.SINGLE_ROW_SUBQUERY_RETURNS_MULTIPLE_ROWS).build().buildException();
+                if ((rhsCurrent == null && (joinType == JoinType.Inner || joinType == JoinType.Semi))
+            range = KeyRange.getKeyRange(lower, range.isLowerInclusive(), upper, range.isUpperInclusive());
+        private final List<Expression> extractNodes = extractNode() ? Collections.<Expression>singletonList(PrefixFunction.this) : Collections.<Expression>emptyList();
+            } else if (column.getSortOrder() == SortOrder.DESC && getTable().rowKeyOrderOptimizable()) {
+                // Append a zero byte if descending since a \xFF byte will be appended to the lowerRange
+                // causing rows to be skipped that should be included. For example, with rows 'ab', 'a',
+        SelectStatement indexSelect = IndexStatementRewriter.translate(FACTORY.select(select, newFrom), resolver, replacement);
+            indexSelect = ParseNodeRewriter.rewrite(indexSelect, new IndexExpressionParseNodeRewriter(indexTableRef.getTable(), indexTableRef.getTableAlias(), connection, indexSelect.getUdfParseNodes()));

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.salted.SaltedTableIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2851//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2851//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2851//console

This message is automatically generated.

> Cleanup anonymous inner classes in phoenix-core/main
> ----------------------------------------------------
>
>                 Key: PHOENIX-5390
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5390
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Neha Gupta
>            Assignee: Neha Gupta
>            Priority: Minor
>         Attachments: PHOENIX-5390-Cleanup-anonymous-classes.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Cleanup anonymous inner classes in phoenix-core/main



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)