You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by GitBox <gi...@apache.org> on 2021/05/03 14:29:53 UTC
[GitHub] [oozie] akki opened a new pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
akki opened a new pull request #57:
URL: https://github.com/apache/oozie/pull/57
https://issues.apache.org/jira/browse/OOZIE-3620
Not sure if you accept PRs yet or if my JIRA patch is the right way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oozie] zuston commented on a change in pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
Posted by GitBox <gi...@apache.org>.
zuston commented on a change in pull request #57:
URL: https://github.com/apache/oozie/pull/57#discussion_r633350438
##########
File path: core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
##########
@@ -85,6 +85,7 @@ protected void generateEvent(WorkflowActionBean wfAction, String wfUser) {
wfAction.getStatus(), wfUser, wfAction.getName(), wfAction.getStartTime(), wfAction.getEndTime());
event.setErrorCode(wfAction.getErrorCode());
event.setErrorMessage(wfAction.getErrorMessage());
+ event.setHadoopId(wfAction.getExternalId());
Review comment:
Actually externalId is not hadoop id. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oozie] zuston commented on pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #57:
URL: https://github.com/apache/oozie/pull/57#issuecomment-842144337
Please upload PR into Oozie jira website. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oozie] zuston commented on a change in pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
Posted by GitBox <gi...@apache.org>.
zuston commented on a change in pull request #57:
URL: https://github.com/apache/oozie/pull/57#discussion_r633350438
##########
File path: core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
##########
@@ -85,6 +85,7 @@ protected void generateEvent(WorkflowActionBean wfAction, String wfUser) {
wfAction.getStatus(), wfUser, wfAction.getName(), wfAction.getStartTime(), wfAction.getEndTime());
event.setErrorCode(wfAction.getErrorCode());
event.setErrorMessage(wfAction.getErrorMessage());
+ event.setHadoopId(wfAction.getExternalId());
Review comment:
Actually externalId is not hadoop id. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oozie] zuston commented on pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #57:
URL: https://github.com/apache/oozie/pull/57#issuecomment-842144337
Please upload PR into Oozie jira website. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oozie] akki commented on a change in pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
Posted by GitBox <gi...@apache.org>.
akki commented on a change in pull request #57:
URL: https://github.com/apache/oozie/pull/57#discussion_r635034589
##########
File path: core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
##########
@@ -85,6 +85,7 @@ protected void generateEvent(WorkflowActionBean wfAction, String wfUser) {
wfAction.getStatus(), wfUser, wfAction.getName(), wfAction.getStartTime(), wfAction.getEndTime());
event.setErrorCode(wfAction.getErrorCode());
event.setErrorMessage(wfAction.getErrorMessage());
+ event.setHadoopId(wfAction.getExternalId());
Review comment:
I had checked in our Oozie database & they seemed to match.
Do you think that is incorrect? How can I fetch `HadoopId` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oozie] akki commented on pull request #57: Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events
Posted by GitBox <gi...@apache.org>.
akki commented on pull request #57:
URL: https://github.com/apache/oozie/pull/57#issuecomment-843887306
Thank you for the suggestion @zuston
I had added a patch to Jira but it was failing earlier so I created this PR. It seems to be accepted by JIRA now when I re-uploaded it again.
Would you suggest me to close this PR? How will the review process of my patch happen in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org