You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by concretevitamin <gi...@git.apache.org> on 2014/04/01 07:30:37 UTC

[GitHub] spark pull request: Blockingly drain all events in LiveListenerBus...

Github user concretevitamin commented on the pull request:

    https://github.com/apache/spark/pull/251#issuecomment-39172164
  
    Is this good to go? I can see the argument that `SparkListenerShutdown` is probably not doing anything now, but removing it should be in another PR. To stick with the current semantics it's more correct to treat the two events as different events?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---