You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/11 03:06:22 UTC
[GitHub] [arrow] jglaser opened a new pull request #7711: fix P9 build
jglaser opened a new pull request #7711:
URL: https://github.com/apache/arrow/pull/7711
Fix build on Power9
This small change addresses the following build error:
```[ 20%] Building CXX object src/arrow/CMakeFiles/arrow_objlib.dir/array/builder_nested.cc.o
In file included from /ccs/proj/stf006/glaser/rapids/arrow/cpp/src/arrow/array/dict_internal.h:35:0,
from /ccs/proj/stf006/glaser/rapids/arrow/cpp/src/arrow/array/builder_dict.cc:22:
/ccs/proj/stf006/glaser/rapids/arrow/cpp/src/arrow/util/hashing.h: In static member function 'static uint32_t arrow::internal::SmallScalarTraits<__vector(4) __bool int>::AsIndex(__vector(4) __bool int)':
/ccs/proj/stf006/glaser/rapids/arrow/cpp/src/arrow/util/hashing.h:495:60: error: cannot convert '__vector(4) int' to 'uint32_t {aka unsigned int}' in return
static uint32_t AsIndex(bool value) { return value ? 1 : 0; }
^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jglaser commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
jglaser commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-656981267
oh, understood. I will submit to xxhash, then. Will take me some time to sort this out, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jglaser commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
jglaser commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657124634
Thank you, @wesm !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7711:
URL: https://github.com/apache/arrow/pull/7711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-656978794
https://issues.apache.org/jira/browse/ARROW-9415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jglaser commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
jglaser commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-656983089
should we leave this open until the upstream PR is merged, and make this a PR for the updated version?
https://github.com/Cyan4973/xxHash/pull/426
@emkornfield Please advise. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657123476
@jglaser can you move the undef into arrow/util/hashing.h until the problem is patches in xxhash? We can remove it whenever we update the vendored code in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657124420
I went ahead and did it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-656980608
@jglaser thank you for the PR. Since this is a vendored library it would likely be better to make the PR upstream and then upgrade here once that is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657133272
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657123476
@jglaser can you move the undef into arrow/util/hashing.h until the problem is fixed in xxhash? We can remove it whenever we update the vendored code in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7711: fix P9 build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-656976907
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657079885
Just curious. Does this happen with gcc or clang? Or both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk edited a comment on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9
Posted by GitBox <gi...@apache.org>.
kiszk edited a comment on pull request #7711:
URL: https://github.com/apache/arrow/pull/7711#issuecomment-657079885
Just curious. Does this happen with gcc x.xx or clang x.xx ? Or both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org