You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Peter Klügl (Created JIRA)" <de...@uima.apache.org> on 2011/10/19 12:26:10 UTC
[jira] [Created] (UIMA-2266) Enable multiple strategies for finding
a suitable type system
Enable multiple strategies for finding a suitable type system
-------------------------------------------------------------
Key: UIMA-2266
URL: https://issues.apache.org/jira/browse/UIMA-2266
Project: UIMA
Issue Type: New Feature
Components: CasEditor
Affects Versions: 2.4.0SDK
Reporter: Peter Klügl
Assignee: Peter Klügl
Priority: Minor
Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (UIMA-2266) Enable multiple
strategies for finding a suitable type system
Posted by "Peter Klügl (Issue Comment Edited JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130525#comment-13130525 ]
Peter Klügl edited comment on UIMA-2266 at 10/19/11 12:04 PM:
--------------------------------------------------------------
First/early version is committed.
I would suggest to extract
- documentToTypeSystemMap.get(casFile.getFullPath().toPortableString())
- TypeSystemLocationPropertyPage.getTypeSystemLocation(casFile.getProject())
also to new strategies with high(= low integer) priority, but that's not really important.
What Do you think about that preference page. It's probably some work (user friendly gui). Should we wait, if it's really necessary?
was (Author: pkluegl):
First/early version is committed.
I would suggest to extract
- documentToTypeSystemMap.get(casFile.getFullPath().toPortableString())
- TypeSystemLocationPropertyPage.getTypeSystemLocation(casFile.getProject())
also to new strategies with high(= low integer) priority, but that's not really important.
What Do you think about that preference page. It's probably some work (user friendly gui). Should be wait, if it's really necessary?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130534#comment-13130534 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
Feedback to your commit. The Cas Editor Ide Plugin is the one which integrates the Cas Editor into the eclipse workspace, that means, opening a CAS from a workspace file, loading the type system from a workspace file.
A file based search strategy should be part of the Ide Plugin and not of the Cas Editor (core). The Cas Editor core part has an extension point for a Cas Document Provider, and this document provider is responsible to find the type system, depending on the integration that can come from many non-IFile sources.
Therefore we should move the strategy code over to the Ide Plugin.
In the DefaulCasDocumentProvider you removed white spaces and did formatting, that makes it difficult to read the diff. Please don't do that in the combination with code changes.
Does the current implementation work for you?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130557#comment-13130557 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
A question about the extension point: Should the schema be defined in the ide plugin? The other extension point is located in the editor plugin. The plugin.xml there also defines it.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130577#comment-13130577 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
I believe this is a good way to cover many of the non-standard ways of opening a CAS. We could define a "Open CAS With" action which first lets you select the Cas Editor (in case there is more than one) and then the type system, or to use a dialog to select one.
Like eclipse "Open With" action but with a second menu layer for the TS selection.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130556#comment-13130556 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
I guess you have settings enabled which change certain things when you save a source file. This might be nice when you write a new source file, but is problematic when you just want to change a few lines in an existing source file.
You can easily see this when you look at the compare before you commit, I actually always do that to check that I don't commit something accidentally.
In eclipse we have an "Open With" action. I always though we need some kind of special opening action which can also choose the type system in case I just want to use a specific one. Did you have something like that in CEV?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (UIMA-2266) Enable multiple strategies for finding
a suitable type system
Posted by "Joern Kottmann (Closed) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joern Kottmann closed UIMA-2266.
--------------------------------
Issues should be "closed" when done, and not be "resolved". We use resolved to indicate that the issue is fixed but we still would like to receive a confirmation that it is really fixed from the original reporter.
Resolved is usually only be used when the reporter and the one who fixes the issue are different persons.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
> Fix For: 2.4.0SDK
>
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130612#comment-13130612 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
The files inside the searchstrategy package don't have the AL 2.0 header, please add it.
And somehow the schema is missing in the Ide Plugin? Or I don't see it?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130550#comment-13130550 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Ok, I will move the code.
What settings do I need except the Apache UIMA Code Conventions? I thought that will configure everything...
I tested the extension point with the "last launch" strategy and it worked just fine.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130578#comment-13130578 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
Yes the scheme should also be defined in the ide plugin, or is there a reason not do to it there? I mean it is an extension point which is provided by the Ide Plugin.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131467#comment-13131467 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
It first tries to get the type system from the default location which is configured in the property page of the project.
Shouldn't it be the other way around? First check the strategies and then fall back to the default location?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131474#comment-13131474 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
Yes, because many users also have multiple type systems per project and the default one might not work. Then the Annotation Editor gives the user the option to choose a different one. That is why I believe the default one should be at the end of the list, the strategies somehow claim they can do the job better than looking at a default location.
The default location lookup should be enhanced to also look at folders, then users would be able to have multiple folders containing CASes and use different type system without choosing the one to use every time they open a CAS.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132633#comment-13132633 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
No, it should stay in the first place. The map ensures that the Cas Editor Ide Plugin just remembers the last used type system.
Is this an issue for TextMarker?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132678#comment-13132678 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Ok, I got the problem now: I debugged a script using one CAS, opened it (CAS Editor remembered the type system), then debugged another script with this CAS. Now I can't open it because the second script introduced some more types resulting in the missing type error.
I fear it is not as simple as to use the search strategies before. I have some that are quite weaker than the remembered type system and should not be applied before that.
Two ideas:
- moving the strategies before the map and I get rid of the other strategies
- making the map a new strategy with some default priority
Both are not really good solutions. Do you have any ideas for this problem?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131469#comment-13131469 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
I did this by purpose because I thought that the property location has a stronger semantic, e.g., if the user specifies a type system then do at all cost use this one.
If it's rather a fall-back type system, then we should move the search strategy code.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132735#comment-13132735 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
I also like to have the option to deactivate the type system map, because in the situation above, I really like to open the CAS with a different type system and don't want to open it with the smaller type system nor see some errors. The strategy would have already selected the optimal type system for my use case.
If you agree, I would include another preference for remembering the type systems.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130570#comment-13130570 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Nope, no special open-with action. I had some more strategies that worked for me but weren't complete or perfect.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132635#comment-13132635 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
It wasn't yet. Maybe, if I open a CAS with the wrong type system, the editor then remembers this one and don't let me open it with another one. I would change it only if problems really occur.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (UIMA-2266) Enable multiple strategies for finding
a suitable type system
Posted by "Joern Kottmann (Updated) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joern Kottmann updated UIMA-2266:
---------------------------------
Fix Version/s: 2.4.0SDK
What is the status here? Can we close the issue?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
> Fix For: 2.4.0SDK
>
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130497#comment-13130497 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Hmm, what we could do is to add a preference page for the priorities, so that the user is able to adapt the priorities to his likings, disabling strategies he doesn't want to be applied.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131458#comment-13131458 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Can I close this issue? It works for me and for additional stuff like user settings in the preference pages a new issue can be created.
What do you think?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130585#comment-13130585 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
I believe eclipse is right with this exception the file is out-of-sync.
When I open a file which is out of sync with the eclipse text editor it shows me a page which says that and then just opens the file a second later. I guess it is syncing it for me in the background.
We could implement a similar solution.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143006#comment-13143006 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
+1, lets create follow up issues.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
> Fix For: 2.4.0SDK
>
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130583#comment-13130583 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
I don't really care. I made the changes and will commit it now.
A thing that annoys me a bit and it located in my code: I get an exception when opening a CAS:
Could not open the editor: Resource is out of sync with the file system: '/CITIE/descriptor/de/uniwue/tm/citie/CitieTypeSystem.xml'.
I know I should refresh the files when changing it, but I already do that and it just won't do it correctly. Maybe I missed somewhere something, but I'm already refreshing everything I can think of.
I fear there is no way to open "out-of sync" descriptors with the cas editor?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132632#comment-13132632 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
I changed the order now. What about documentToTypeSystemMap? Should that also be applied after the search strategies?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130525#comment-13130525 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
First/early version is committed.
I would suggest to extract
- documentToTypeSystemMap.get(casFile.getFullPath().toPortableString())
- TypeSystemLocationPropertyPage.getTypeSystemLocation(casFile.getProject())
also to new strategies with high(= low integer) priority, but that's not really important.
What Do you think about that preference page. It's probably some work (user friendly gui). Should be wait, if it's really necessary?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143003#comment-13143003 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Two things are still missing: setting of the user for the priorities and an option to deactivate the type system mapping. I think we can close it for 2.4.0SDK and create a new issue for the next release.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
> Fix For: 2.4.0SDK
>
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132699#comment-13132699 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
We should do two things to improve this:
a) It should be possible to open the Annotation Editor in read-only if there are types which are not contained in the TS. It should be configurable if that is done or an error is displayed.
b) In the case the user wants to see an error, the error page should have the option to reopen the editor with a selected type system.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130531#comment-13130531 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
The first one ensures that a type system which a user once selected is remembered while the Cas Editor is running. One issue with that is, that is makes it difficult to re-open a CAS file with a different type system.
I believe we should at least keep the documenToTypeSystemMap in the DefaultDocumentProvider and add a configuration where a user can enable/disable it.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130493#comment-13130493 ]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
Here is previous comment about this issue:
https://issues.apache.org/jira/browse/UIMA-2252?focusedCommentId=13130480&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13130480
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130623#comment-13130623 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Sorry, I will fix that. I have some problems with my SVN client right now.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131653#comment-13131653 ]
Peter Klügl commented on UIMA-2266:
-----------------------------------
Another thing: It would be nice to be able to lookup up the name of the actual type system that was used in the cas editor. Something like a tooltip on the title tab or something. I opened a CAS with a wrong type system, got the exception because of the missing definitions and didn't know what type system I used.
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (UIMA-2266) Enable multiple strategies for
finding a suitable type system
Posted by "Peter Klügl (Resolved JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Klügl resolved UIMA-2266.
-------------------------------
Resolution: Fixed
Functionality added. Missing features deferred to new issue UIMA-2278
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
> Fix For: 2.4.0SDK
>
>
> Add an extension point for type system search strategies (maybe with priorities). The different strategies need then to be applied in DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira