[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8514: [fix] cluster_name = cluster_name, not cluster_id

[GitBox <gi...@apache.org>]

serenajiang commented on a change in pull request #8514: [fix] cluster_name = cluster_name, not cluster_id
URL: https://github.com/apache/incubator-superset/pull/8514#discussion_r343368185
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -1612,7 +1612,7 @@ def query_datasources_by_name(
     ) -> List["DruidDatasource"]:
         return (
             session.query(cls)
-            .filter_by(cluster_name=database.id)
+            .filter_by(cluster_name=database.database_name)
 
 Review comment:
   @michellethomas 
   This didn't cause any problems for us because we use our own security manager, so this function isn't used. 
   
   I did a little more digging, and I'm not entirely certain that `cluster_name=database.database_name` is correct, since clusters != databases in our tables. Maybe this line should just be removed? Do you know anyone with more context on this kind of thing? Either way, this change won't cause any (more) problems, but it does seem wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org