You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2016/03/16 20:44:03 UTC
[GitHub] incubator-metron pull request: METRON-70 Create service wrapper fo...
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/47
METRON-70 Create service wrapper for Metron pcap service
### Changes
Created a service wrapper for the Metron pcap service.
### Validation
- [x] Full deployment test on live EC2 cluster.
- [x] License Check
- [x] Integration Tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-70
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 9ce8c78e956eff181a4ae3578bd7b2f68d9f9bc1
Author: Nick Allen <ni...@nickallen.org>
Date: 2016-03-15T15:20:33Z
METRON-70 Created service wrapper for Metron pcap service
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-70 Create service wrapper fo...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/47#issuecomment-197539298
This looks good to me, but I'm going to defer to @merrimanr to give it a second glance since he's in that code right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-70 Create service wrapper fo...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/47#issuecomment-197512857
@merrimanr - Take a quick look at the changes made to the pcap service. Hopefully minimal impact to what you are working on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-70 Create service wrapper fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-70 Create service wrapper fo...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/47#issuecomment-197542461
+1 from me. Only change I had to make was the -port option and it looks like you found it as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---