[jira] [Commented] (FOP-3160) split packages within the FOP codebase

["Jason Harrop (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FOP-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823386#comment-17823386 ] 

Jason Harrop commented on FOP-3160:
-----------------------------------

With FOP 2.9, this issue can manifest as:

```
Error occurred during initialization of boot layer
java.lang.module.ResolutionException: Modules fop.core and fop.events export package org.apache.fop.tools to module batik.anim
```

FOP 2.8 doesn't seem to have this issue.

> split packages within the FOP codebase
> --------------------------------------
>
>                 Key: FOP-3160
>                 URL: https://issues.apache.org/jira/browse/FOP-3160
>             Project: FOP
>          Issue Type: Improvement
>            Reporter: Samael Bate
>            Priority: Major
>              Labels: jpms
>
> whilst taking a look at modularising the project (see: FOP-3159) I found that that package names are duplicated across the maven sub-modules.
> For example, both fop-core and fop-utils have _org.apache.fop.util.text._
>  
> {code:java}
> [ERROR] the unnamed module reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] the unnamed module reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] the unnamed module reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] the unnamed module reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module commons.logging reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module commons.logging reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module commons.logging reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module commons.logging reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module batik.awt.util reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module batik.awt.util reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module batik.awt.util reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module batik.awt.util reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module qdox reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module qdox reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module qdox reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module qdox reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module org.apache.commons.io reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module org.apache.commons.io reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module org.apache.commons.io reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module org.apache.commons.io reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module ant reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module ant reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module ant reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module ant reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module servlet.api reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module servlet.api reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module servlet.api reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module servlet.api reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
>  {code}
> The project should be refactored a bit so that packages are not split across modules. This will be needed for JPMS



--
This message was sent by Atlassian Jira
(v8.20.10#820010)