You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/10/19 05:20:35 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request #1162: WIP: Modern app template
dpogue opened a new pull request #1162:
URL: https://github.com/apache/cordova-ios/pull/1162
Depends on https://github.com/apache/cordova-ios/pull/1158
### Platforms affected
iOS
### Motivation and Context
Make the app template project match a modern Xcode-created iOS app project.
### Description
* Restructures the Xcode project to more closely match what gets generated when you create a new Objective C iOS app with Xcode.
* Uses a storyboard for the main ViewController rather than a xib file.
* Renames Images.xcassets to Assets.xcassets.
* Uses CordovaLib from Swift Package Manager rather than a subproject.
* Enables Mac Catalyst support.
* Adopts SceneDelegate API on iOS 13+.
### Testing
Created an app with `npx cordova platform add ~/Coding/cordova-ios`.
Ran the app successfully on iOS 11, iOS 12, iOS 13, iOS 14, and iOS 15. Also ran the app successfully on macOS with Catalyst.
Unit tests pass.
This need **lots** of testing to make sure the SceneDelegate stuff isn't interfering and blocking stuff that used to fire on the AppDelegate. Might need to introduce a CDVSceneDelegate in CordovaLib to account for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on pull request #1162: WIP: Modern app template
Posted by GitBox <gi...@apache.org>.
dpogue commented on pull request #1162:
URL: https://github.com/apache/cordova-ios/pull/1162#issuecomment-955954694
I'm breaking this up into smaller pull requests for easier review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue closed pull request #1162: WIP: Modern app template
Posted by GitBox <gi...@apache.org>.
dpogue closed pull request #1162:
URL: https://github.com/apache/cordova-ios/pull/1162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org