You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/02 19:17:43 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1283: HDDS-4057. Failed acceptance test missing from bundle
adoroszlai opened a new pull request #1283:
URL: https://github.com/apache/hadoop-ozone/pull/1283
## What changes were proposed in this pull request?
The problem is caused by this line in `test-all.sh`:
https://github.com/apache/hadoop-ozone/blob/e219aae7c7bcd8eacd592ca2ccfcf58626477f37/hadoop-ozone/dist/src/main/compose/test-all.sh#L28
because `testlib.sh` turns on "exit on error":
https://github.com/apache/hadoop-ozone/blob/e219aae7c7bcd8eacd592ca2ccfcf58626477f37/hadoop-ozone/dist/src/main/compose/testlib.sh#L17
So `test-all.sh` exits after the first failed `test.sh` execution, `... is FAILED` is not present in output.
The fix is simple: temporarily turn off "exit on error" before running `test.sh`, then turn it back on. We also need to make `rebot` return zero code even if some tests failed.
https://issues.apache.org/jira/browse/HDDS-4057
## How was this patch tested?
Added two always failing tests and two environments. These can be used to test failure handling in acceptance test runner. Without the fix, only the first test in the first environment is run, and its logs are not copied to `target/acceptance`:
```
$ OZONE_ACCEPTANCE_SUITE=failing ./hadoop-ozone/dev-support/checks/acceptance.sh
...
Test1 :: This test always fails | FAIL |
...
Output: /tmp/smoketest/failing1/result/robot-failing1-failing1-test1-scm.xml
$ ls -1 target/acceptance
```
With the fix, both tests in both environments are run:
```
$ OZONE_ACCEPTANCE_SUITE=failing ./hadoop-ozone/dev-support/checks/acceptance.sh
...
Test1 :: This test always fails | FAIL |
...
Output: /tmp/smoketest/failing1/result/robot-failing1-failing1-test1-scm.xml
...
ERROR: Test execution of ./failing1 is FAILED!!!!
...
Test1 :: This test always fails | FAIL |
...
Output: /tmp/smoketest/failing2/result/robot-failing2-failing2-test1-scm.xml
...
ERROR: Test execution of ./failing2 is FAILED!!!!
$ ls -1 target/acceptance
docker-failing1-failing1-test1-scm.log
docker-failing2-failing2-test1-scm.log
failing1.xml
failing2.xml
log.html
report.html
summary.html
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/937941098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1283: HDDS-4057. Failed acceptance test missing from bundle
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1283:
URL: https://github.com/apache/hadoop-ozone/pull/1283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1283: HDDS-4057. Failed acceptance test missing from bundle
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1283:
URL: https://github.com/apache/hadoop-ozone/pull/1283#issuecomment-671940983
> 1. `set +e` and `set -e`
> 1. `failing1-2`
I agree it would be nice to implement both: consistent `set -e` and test env. reorganization. Created HDDS-4100 and HDDS-4101 for these.
> Not clear why do we need the `set +e` here if we introduce `--nostatusrc`
`test.sh` execution also needs to "ignore" errors, otherwise we may not reach `rebot`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1283: HDDS-4057. Failed acceptance test missing from bundle
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1283:
URL: https://github.com/apache/hadoop-ozone/pull/1283#issuecomment-672787744
Thanks @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1283: HDDS-4057. Failed acceptance test missing from bundle
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1283:
URL: https://github.com/apache/hadoop-ozone/pull/1283#issuecomment-672782797
> test.sh execution also needs to "ignore" errors, otherwise we may not reach rebot.
Yes, that's a good question. The scripts of `hadoop-ozone/dev-support/checks/*.sh` have very simple contract: in case of failure a non-zero shell code should be returned.
If we would like to keep the same contract for the individual test.sh files we need this `set +/-e` trick. But in this case we couldn't differentiate between errors (in environment / script) and failures (in robot tests).
Another option what I started to follow is to make `test.sh` return with 255 only if the test execution failed in the script, and the result of the test can be checked from the robot.xml files.
Don't know which one is better.
Anyway, let me merge this PR and we can continue to think about theses questions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org