You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by kg...@apache.org on 2022/04/13 13:16:11 UTC
[superset] branch master updated: chore(explore): Change labels "Group by"/"Series" to "Dimensions" (#19647)
This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new de9fb2109d chore(explore): Change labels "Group by"/"Series" to "Dimensions" (#19647)
de9fb2109d is described below
commit de9fb2109d2e64cb926d04733dc6a9855816f4de
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Wed Apr 13 15:16:03 2022 +0200
chore(explore): Change labels "Group by"/"Series" to "Dimensions" (#19647)
---
.../superset-ui-chart-controls/src/shared-controls/dndControls.tsx | 4 ++--
.../packages/superset-ui-chart-controls/src/shared-controls/index.tsx | 4 ++--
.../plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts | 2 +-
.../plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts | 2 +-
.../plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx | 2 +-
superset-frontend/src/explore/controls.jsx | 4 ++--
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
index 44b4bcc186..44e0d2fb63 100644
--- a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
@@ -28,7 +28,7 @@ import { TIME_COLUMN_OPTION, TIME_FILTER_LABELS } from '../constants';
export const dndGroupByControl: SharedControlConfig<'DndColumnSelect'> = {
type: 'DndColumnSelect',
- label: t('Group by'),
+ label: t('Dimensions'),
default: [],
description: t(
'One or many columns to group by. High cardinality groupings should include a series limit ' +
@@ -58,7 +58,7 @@ export const dndColumnsControl: typeof dndGroupByControl = {
export const dndSeries: typeof dndGroupByControl = {
...dndGroupByControl,
- label: t('Series'),
+ label: t('Dimensions'),
multi: false,
default: null,
description: t(
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
index ec50568315..382fcb5bb3 100644
--- a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
@@ -103,7 +103,7 @@ type SelectDefaultOption = {
const groupByControl: SharedControlConfig<'SelectControl', ColumnMeta> = {
type: 'SelectControl',
- label: t('Group by'),
+ label: t('Dimensions'),
multi: true,
freeForm: true,
clearable: true,
@@ -403,7 +403,7 @@ const sort_by: SharedControlConfig<'MetricsControl'> = {
const series: typeof groupByControl = {
...groupByControl,
- label: t('Series'),
+ label: t('Dimensions'),
multi: false,
default: null,
description: t(
diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
index 3df9e00057..278743d472 100644
--- a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
+++ b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
@@ -106,7 +106,7 @@ const config: ControlPanelConfig = {
],
controlOverrides: {
groupby: {
- label: t('Series'),
+ label: t('Dimensions'),
validators: [validateNonEmpty],
mapStateToProps: (state, controlState) => {
const groupbyProps =
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts b/superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts
index a9456dce38..f8e5cbb629 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts
@@ -125,7 +125,7 @@ const config: ControlPanelConfig = {
],
controlOverrides: {
groupby: {
- label: t('Series'),
+ label: t('Dimensions'),
description: t('Categories to group by on the x-axis.'),
},
columns: {
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx
index 81af7d3963..581d98c6b9 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx
@@ -39,7 +39,7 @@ const config: ControlPanelConfig = {
name: 'groupby',
config: {
...sharedControls.groupby,
- label: t('Group by'),
+ label: t('Dimensions'),
description: t('Columns to group by'),
},
},
diff --git a/superset-frontend/src/explore/controls.jsx b/superset-frontend/src/explore/controls.jsx
index 974a79b9af..daba78ca6d 100644
--- a/superset-frontend/src/explore/controls.jsx
+++ b/superset-frontend/src/explore/controls.jsx
@@ -120,7 +120,7 @@ const groupByControl = {
type: 'SelectControl',
multi: true,
freeForm: true,
- label: t('Group by'),
+ label: t('Dimensions'),
default: [],
includeTime: false,
description: t(
@@ -393,7 +393,7 @@ export const controls = {
series: {
...groupByControl,
- label: t('Series'),
+ label: t('Dimensions'),
multi: false,
default: null,
description: t(