You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/23 01:39:52 UTC

[GitHub] ryanbarry opened a new issue #6935: non-standard druid version strings break druid connector

ryanbarry opened a new issue #6935: non-standard druid version strings break druid connector
URL: https://github.com/apache/incubator-superset/issues/6935
 
 
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
     http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   
   ### Superset version
   master (ec6657ab)
   
   ### Expected results
   Be able to connect to druid cluster and retrieve metadata.
   
   ### Actual results
   Errors encountered connecting to druid while parsing the clusters' version strings in the druid connector [here](https://github.com/apache/incubator-superset/blob/ec6657ab2d07d6982a454e20745445ab673a6a0f/superset/connectors/druid/models.py#L549), [here](https://github.com/apache/incubator-superset/blob/ec6657ab2d07d6982a454e20745445ab673a6a0f/superset/connectors/druid/models.py#L566), and [here](https://github.com/apache/incubator-superset/blob/ec6657ab2d07d6982a454e20745445ab673a6a0f/superset/connectors/druid/models.py#L1076) because our internal build of druid uses a different version string schema that isn't parsable by distutils.version's LooseVersion.
   
   For our case, I patched our build of the code manually since we're only running versions of druid later than those checks are looking for, but I wanted to know if there would be a recommended way to patch this that I could submit for inclusion here. Maybe a configuration setting or something to avoid doing the check?
   
   ### Steps to reproduce
   Connect superset to a druid cluster that uses a version string like `internal-1234` and hit the "Refresh Druid Metadata" endpoint and watch the error spit out about comparing string to int with `<` operator.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org