You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/31 17:53:00 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6506: Standardize `RUST_LOG` configuration test setup
alamb opened a new pull request, #6506:
URL: https://github.com/apache/arrow-datafusion/pull/6506
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/6505
# Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/6495 and a follow up from https://github.com/apache/arrow-datafusion/pull/6505
# Rationale for this change
Basically, `[#ctor]` is used to do one-time initialization of logging in the tests and it is not done consistently across the codebase, perhaps leading to issues like https://github.com/apache/arrow-datafusion/issues/6495
# What changes are included in this PR?
This PR moves the initialization to the main module and adds comments explaining what is going on.
# Are these changes tested?
Covered by existing tests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
no
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6506: Standardize `RUST_LOG` configuration test setup
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6506:
URL: https://github.com/apache/arrow-datafusion/pull/6506#issuecomment-1573966808
Thanks for the review @r4ntix !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6506: Standardize `RUST_LOG` configuration test setup
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6506:
URL: https://github.com/apache/arrow-datafusion/pull/6506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org