You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/27 15:23:32 UTC

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

caspermeijn opened a new pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253
 
 
   This adds the bsp boilerplate including the pin definitions for the peripherals. A description of the device can be found here: https://wiki.pine64.org/index.php/PineTime
   
   I plan to add drivers for the peripherals later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605466963
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-28 16:02:53)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 12 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605467010
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605525758
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605619858
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399669093
 
 

 ##########
 File path: hw/bsp/pinetime/syscfg.yml
 ##########
 @@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Settings this BSP defines.
+syscfg.defs:
+
+# Settings this BSP overrides.
+syscfg.vals:
 
 Review comment:
   I created a PR for the blinky tutorial: https://github.com/apache/mynewt-documentation/pull/91
   
   And I added the flash areas as with most other BSP.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605095113
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-27 16:28:15)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   * <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a>
   
   ## 12 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605525744
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-28 22:05:02)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 13 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605439557
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/pinetime/src/sbrk.c
   <details>
   
   ```diff
   @@ -23,7 +23,7 @@
    static char *brk __attribute__ ((section (".data")));
    
    void
   -_sbrkInit(char *base, char *limit) 
   +_sbrkInit(char *base, char *limit)
    {
        sbrkBase = base;
        sbrkLimit = limit;
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399669093
 
 

 ##########
 File path: hw/bsp/pinetime/syscfg.yml
 ##########
 @@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Settings this BSP defines.
+syscfg.defs:
+
+# Settings this BSP overrides.
+syscfg.vals:
 
 Review comment:
   I added the flash areas as with most other BSP.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399715087
 
 

 ##########
 File path: hw/bsp/pinetime/README.md
 ##########
 @@ -0,0 +1,56 @@
+<!--
+#
+#   Copyright 2020 Casper Meijn <ca...@meijn.net>
+#
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+#
+-->
+
+# mynewt bsp for PineTime
+
+## Overview
+
+This is a board support package for the Pine64 PineTime smartwatch. See [device wiki](https://wiki.pine64.org/index.php/PineTime) for documentation. See [store](https://store.pine64.org/?product=pinetime-dev-kit) for buying a dev kit.
+
+## Status
+
+Currently the status is: incomplete.
+
+Available drivers:
+
+- Only pin defenitions are available
+
+## Usage
+
+The bsp is configured to use openocd and a ST-LINK programmer. Connect your device to the ST-LINK and it to your computer. Then run the following commando to start make the LCD backlight blink:
+
+```bash
+newt new blinky-pinetime
+cd blinky-pinetime
+newt sync
+
+newt target create boot-pinetime
+newt target set boot-pinetime \
+    app=@mcuboot/boot/mynewt \
+    bsp=@apache-mynewt-core/hw/bsp/pinetime \
+    build_profile=optimized
+newt build boot-pinetime
+newt load boot-pinetime
+
+newt target create blinky-pinetime
+newt target set blinky-pinetime \
+    app=apps/blinky \
+    bsp=@apache-mynewt-core/hw/bsp/pinetime \
+    build_profile=debug
+newt run blinky-pinetime 0
+```
 
 Review comment:
   I created a blinky tutorial for PineTime. I also creates a new section in OS User Guide for Board support. The first page is the status of PineTime BSP.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605095113
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-27 16:28:15)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   * <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a>
   
   ## 12 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/0283453ed8bbdfcac69715131c5855979c3e0646/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605466963
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-28 16:02:53)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 12 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/623fc0af9778922c8dece2107c4c8e0bdb89c367/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605095196
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/pinetime/include/bsp/bsp.h
   <details>
   
   ```diff
   @@ -37,55 +37,55 @@
    
    #define RAM_SIZE        0x10000
    
   -// Battery charger SMG40561
   -#define CHARGER_POWER_PRESENCE_PIN  19 //P0.19 POWER PRESENCE INDICATION IN
   -#define CHARGER_CHARGE_PIN      12 //P0.12 CHARGE INDICATION         IN
   -#define BATTERY_VOLTAGE_PIN     31 //P0.31 BATTERYVOLTAGE (Analog)   IN
   +/* Battery charger SMG40561 */
   +#define CHARGER_POWER_PRESENCE_PIN  19 /*P0.19 POWER PRESENCE INDICATION IN */
   +#define CHARGER_CHARGE_PIN      12 /*P0.12 CHARGE INDICATION         IN */
   +#define BATTERY_VOLTAGE_PIN     31 /*P0.31 BATTERYVOLTAGE (Analog)   IN */
    
   -// Periphiral power control
   -#define POWER_CONTROL_PIN       24 //P0.24 3V3POWERCONTROL      OUT
   +/* Periphiral power control */
   +#define POWER_CONTROL_PIN       24 /*P0.24 3V3POWERCONTROL      OUT */
    
   -// 2 wire power button
   -#define PUSH_BUTTON_IN_PIN      13 //P0.13 PUSH BUTTON_IN       IN
   -#define PUSH_BUTTON_OUT_PIN     15 //P0.15 PUSH BUTTON_OUT      OUT
   +/* 2 wire power button */
   +#define PUSH_BUTTON_IN_PIN      13 /*P0.13 PUSH BUTTON_IN       IN */
   +#define PUSH_BUTTON_OUT_PIN     15 /*P0.15 PUSH BUTTON_OUT      OUT */
    
   -// Vibrator motor
   -#define VIBRATOR_PIN            16 //P0.16 VIBRATOR             OUT
   +/* Vibrator motor */
   +#define VIBRATOR_PIN            16 /*P0.16 VIBRATOR             OUT */
    
   -// LCD display
   -#define LCD_SPI_CLOCK_PIN        2 //P0.02 SPI-SCK, LCD_SCK     OUT
   -#define LCD_SPI_MOSI_PIN         3 //P0.03 SPI-MOSI, LCD_SDI    OUT
   -#define LCD_DET_PIN              9 //P0.09 LCD_DET              OUT
   -#define LCD_WRITE_PIN           18 //P0.18 LCD_RS               OUT
   -#define LCD_BACKLIGHT_LOW_PIN   14 //P0.14 LCD_BACKLIGHT_LOW    OUT
   -#define LCD_BACKLIGHT_MED_PIN   22 //P0.22 LCD_BACKLIGHT_MID    OUT
   -#define LCD_BACKLIGHT_HIGH_PIN  23 //P0.23 LCD_BACKLIGHT_HIGH   OUT
   -#define LCD_CHIP_SELECT_PIN     25 //P0.25 LCD_CS               OUT
   -#define LCD_RESET_PIN           26 //P0.26 LCD_RESET            OUT
   +/* LCD display */
   +#define LCD_SPI_CLOCK_PIN        2 /*P0.02 SPI-SCK, LCD_SCK     OUT */
   +#define LCD_SPI_MOSI_PIN         3 /*P0.03 SPI-MOSI, LCD_SDI    OUT */
   +#define LCD_DET_PIN              9 /*P0.09 LCD_DET              OUT */
   +#define LCD_WRITE_PIN           18 /*P0.18 LCD_RS               OUT */
   +#define LCD_BACKLIGHT_LOW_PIN   14 /*P0.14 LCD_BACKLIGHT_LOW    OUT */
   +#define LCD_BACKLIGHT_MED_PIN   22 /*P0.22 LCD_BACKLIGHT_MID    OUT */
   +#define LCD_BACKLIGHT_HIGH_PIN  23 /*P0.23 LCD_BACKLIGHT_HIGH   OUT */
   +#define LCD_CHIP_SELECT_PIN     25 /*P0.25 LCD_CS               OUT */
   +#define LCD_RESET_PIN           26 /*P0.26 LCD_RESET            OUT */
    
   -// SPI NOR Flash PM25LV512
   -#define FLASH_CLOCK_PIN          2 //P0.02 SPI-SCK, LCD_SCK     OUT
   -#define FLASH_MOSI_PIN           3 //P0.03 SPI-MOSI, LCD_SDI    OUT
   -#define FLASH_MISO_PIN           4 //P0.04 SPI-MISO             IN    
   -#define FLASH_SELECT_PIN         5 //P0.05 SPI-CE#(SPI-NOR)     OUT
   +/* SPI NOR Flash PM25LV512 */
   +#define FLASH_CLOCK_PIN          2 /*P0.02 SPI-SCK, LCD_SCK     OUT */
   +#define FLASH_MOSI_PIN           3 /*P0.03 SPI-MOSI, LCD_SDI    OUT */
   +#define FLASH_MISO_PIN           4 /*P0.04 SPI-MISO             IN */
   +#define FLASH_SELECT_PIN         5 /*P0.05 SPI-CE#(SPI-NOR)     OUT */
    
   -// Accelerometer i2c BMA421
   -#define ACCELEROMETER_DATA_PIN   6 //P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O
   -#define ACCELEROMETER_CLOCK_PIN  7 //P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT
   -#define ACCELEROMETER_INT_PIN    8 //P0.08 BMA421-INT                       IN
   +/* Accelerometer i2c BMA421 */
   +#define ACCELEROMETER_DATA_PIN   6 /*P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O */
   +#define ACCELEROMETER_CLOCK_PIN  7 /*P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT */
   +#define ACCELEROMETER_INT_PIN    8 /*P0.08 BMA421-INT                       IN */
    
   -// Touchscreen controller i2c
   -#define TOUCH_DATA_PIN           6 //P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O
   -#define TOUCH_CLOCK_PIN          7 //P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT
   -#define TOUCH_INT_PIN           28 //P0.28 TP_INT                           IN
   -#define TOUCH_RESET_PIN         10 //P0.10 TP_RESET                         OUT
   +/* Touchscreen controller i2c */
   +#define TOUCH_DATA_PIN           6 /*P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O */
   +#define TOUCH_CLOCK_PIN          7 /*P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT */
   +#define TOUCH_INT_PIN           28 /*P0.28 TP_INT                           IN */
   +#define TOUCH_RESET_PIN         10 /*P0.10 TP_RESET                         OUT */
    
   -// Heartrate sensor i2c
   -#define HEARTRATE_DATA_PIN       6 //P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O
   -#define HEARTRATE_CLOCK_PIN      7 //P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT
   -#define HEARTRATE_INT_PIN       30 //P0.30 HRS3300-TEST                     IN
   +/* Heartrate sensor i2c */
   +#define HEARTRATE_DATA_PIN       6 /*P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O */
   +#define HEARTRATE_CLOCK_PIN      7 /*P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT */
   +#define HEARTRATE_INT_PIN       30 /*P0.30 HRS3300-TEST                     IN */
    
   -// apps/blinky support
   +/* apps/blinky support */
    #define LED_BLINK_PIN   LCD_BACKLIGHT_HIGH_PIN
    
    
   ```
   
   </details>
   
   #### hw/bsp/pinetime/src/sbrk.c
   <details>
   
   ```diff
   @@ -23,7 +23,8 @@
    static char *brk __attribute__ ((section (".data")));
    
    void
   -_sbrkInit(char *base, char *limit) {
   +_sbrkInit(char *base, char *limit)
   +{
        sbrkBase = base;
        sbrkLimit = limit;
        brk = base;
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399691980
 
 

 ##########
 File path: hw/bsp/pinetime/syscfg.yml
 ##########
 @@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Settings this BSP defines.
+syscfg.defs:
+
+# Settings this BSP overrides.
+syscfg.vals:
 
 Review comment:
   Yes, take look at [bsp/nordic_pca10040](https://github.com/apache/mynewt-core/blob/master/hw/bsp/nordic_pca10040) . You will probably need to upbate your `syscfg.yml` and `hal_bsp_get_nvic_priority` to be able to build and run [bleprph](https://github.com/apache/mynewt-nimble/tree/master/apps/bleprph).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605439518
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-28 12:15:07)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 12 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399640810
 
 

 ##########
 File path: hw/bsp/pinetime/pkg.yml
 ##########
 @@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "hw/bsp/pinetime"
+pkg.type: bsp
+pkg.description: "BSP definition for the Pine64 PineTime smartwatch"
+pkg.author: "Apache Mynewt <de...@mynewt.apache.org>"
+pkg.homepage: "http://mynewt.apache.org/"
+pkg.keywords:
+    - nrf52
+    - Pine64
+    - PineTime
+
+pkg.cflags:
+    - '-DNRF52'
+    # TODO: Move to more specific variable, however this currently causes a build failure '-DNRF52832_XXAA'
 
 Review comment:
   I believe some library didn't build because it expected `NRF52`. I will look at it again and fix the actual problem ;-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605619859
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-29 11:11:24)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 11 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399692611
 
 

 ##########
 File path: hw/bsp/pinetime/pkg.yml
 ##########
 @@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "hw/bsp/pinetime"
+pkg.type: bsp
+pkg.description: "BSP definition for the Pine64 PineTime smartwatch"
+pkg.author: "Apache Mynewt <de...@mynewt.apache.org>"
+pkg.homepage: "http://mynewt.apache.org/"
+pkg.keywords:
+    - nrf52
+    - Pine64
+    - PineTime
+
+pkg.cflags:
+    - '-DNRF52'
+    # TODO: Move to more specific variable, however this currently causes a build failure '-DNRF52832_XXAA'
 
 Review comment:
   Ok, nevermind, this is dealt with on nrfx, `NRF52` is ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605095196
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/pinetime/include/bsp/bsp.h
   <details>
   
   ```diff
   @@ -37,55 +37,55 @@
    
    #define RAM_SIZE        0x10000
    
   -// Battery charger SMG40561
   -#define CHARGER_POWER_PRESENCE_PIN  19 //P0.19 POWER PRESENCE INDICATION IN
   -#define CHARGER_CHARGE_PIN      12 //P0.12 CHARGE INDICATION         IN
   -#define BATTERY_VOLTAGE_PIN     31 //P0.31 BATTERYVOLTAGE (Analog)   IN
   +/* Battery charger SMG40561 */
   +#define CHARGER_POWER_PRESENCE_PIN  19 /*P0.19 POWER PRESENCE INDICATION IN */
   +#define CHARGER_CHARGE_PIN      12 /*P0.12 CHARGE INDICATION         IN */
   +#define BATTERY_VOLTAGE_PIN     31 /*P0.31 BATTERYVOLTAGE (Analog)   IN */
    
   -// Periphiral power control
   -#define POWER_CONTROL_PIN       24 //P0.24 3V3POWERCONTROL      OUT
   +/* Periphiral power control */
   +#define POWER_CONTROL_PIN       24 /*P0.24 3V3POWERCONTROL      OUT */
    
   -// 2 wire power button
   -#define PUSH_BUTTON_IN_PIN      13 //P0.13 PUSH BUTTON_IN       IN
   -#define PUSH_BUTTON_OUT_PIN     15 //P0.15 PUSH BUTTON_OUT      OUT
   +/* 2 wire power button */
   +#define PUSH_BUTTON_IN_PIN      13 /*P0.13 PUSH BUTTON_IN       IN */
   +#define PUSH_BUTTON_OUT_PIN     15 /*P0.15 PUSH BUTTON_OUT      OUT */
    
   -// Vibrator motor
   -#define VIBRATOR_PIN            16 //P0.16 VIBRATOR             OUT
   +/* Vibrator motor */
   +#define VIBRATOR_PIN            16 /*P0.16 VIBRATOR             OUT */
    
   -// LCD display
   -#define LCD_SPI_CLOCK_PIN        2 //P0.02 SPI-SCK, LCD_SCK     OUT
   -#define LCD_SPI_MOSI_PIN         3 //P0.03 SPI-MOSI, LCD_SDI    OUT
   -#define LCD_DET_PIN              9 //P0.09 LCD_DET              OUT
   -#define LCD_WRITE_PIN           18 //P0.18 LCD_RS               OUT
   -#define LCD_BACKLIGHT_LOW_PIN   14 //P0.14 LCD_BACKLIGHT_LOW    OUT
   -#define LCD_BACKLIGHT_MED_PIN   22 //P0.22 LCD_BACKLIGHT_MID    OUT
   -#define LCD_BACKLIGHT_HIGH_PIN  23 //P0.23 LCD_BACKLIGHT_HIGH   OUT
   -#define LCD_CHIP_SELECT_PIN     25 //P0.25 LCD_CS               OUT
   -#define LCD_RESET_PIN           26 //P0.26 LCD_RESET            OUT
   +/* LCD display */
   +#define LCD_SPI_CLOCK_PIN        2 /*P0.02 SPI-SCK, LCD_SCK     OUT */
   +#define LCD_SPI_MOSI_PIN         3 /*P0.03 SPI-MOSI, LCD_SDI    OUT */
   +#define LCD_DET_PIN              9 /*P0.09 LCD_DET              OUT */
   +#define LCD_WRITE_PIN           18 /*P0.18 LCD_RS               OUT */
   +#define LCD_BACKLIGHT_LOW_PIN   14 /*P0.14 LCD_BACKLIGHT_LOW    OUT */
   +#define LCD_BACKLIGHT_MED_PIN   22 /*P0.22 LCD_BACKLIGHT_MID    OUT */
   +#define LCD_BACKLIGHT_HIGH_PIN  23 /*P0.23 LCD_BACKLIGHT_HIGH   OUT */
   +#define LCD_CHIP_SELECT_PIN     25 /*P0.25 LCD_CS               OUT */
   +#define LCD_RESET_PIN           26 /*P0.26 LCD_RESET            OUT */
    
   -// SPI NOR Flash PM25LV512
   -#define FLASH_CLOCK_PIN          2 //P0.02 SPI-SCK, LCD_SCK     OUT
   -#define FLASH_MOSI_PIN           3 //P0.03 SPI-MOSI, LCD_SDI    OUT
   -#define FLASH_MISO_PIN           4 //P0.04 SPI-MISO             IN    
   -#define FLASH_SELECT_PIN         5 //P0.05 SPI-CE#(SPI-NOR)     OUT
   +/* SPI NOR Flash PM25LV512 */
   +#define FLASH_CLOCK_PIN          2 /*P0.02 SPI-SCK, LCD_SCK     OUT */
   +#define FLASH_MOSI_PIN           3 /*P0.03 SPI-MOSI, LCD_SDI    OUT */
   +#define FLASH_MISO_PIN           4 /*P0.04 SPI-MISO             IN */
   +#define FLASH_SELECT_PIN         5 /*P0.05 SPI-CE#(SPI-NOR)     OUT */
    
   -// Accelerometer i2c BMA421
   -#define ACCELEROMETER_DATA_PIN   6 //P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O
   -#define ACCELEROMETER_CLOCK_PIN  7 //P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT
   -#define ACCELEROMETER_INT_PIN    8 //P0.08 BMA421-INT                       IN
   +/* Accelerometer i2c BMA421 */
   +#define ACCELEROMETER_DATA_PIN   6 /*P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O */
   +#define ACCELEROMETER_CLOCK_PIN  7 /*P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT */
   +#define ACCELEROMETER_INT_PIN    8 /*P0.08 BMA421-INT                       IN */
    
   -// Touchscreen controller i2c
   -#define TOUCH_DATA_PIN           6 //P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O
   -#define TOUCH_CLOCK_PIN          7 //P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT
   -#define TOUCH_INT_PIN           28 //P0.28 TP_INT                           IN
   -#define TOUCH_RESET_PIN         10 //P0.10 TP_RESET                         OUT
   +/* Touchscreen controller i2c */
   +#define TOUCH_DATA_PIN           6 /*P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O */
   +#define TOUCH_CLOCK_PIN          7 /*P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT */
   +#define TOUCH_INT_PIN           28 /*P0.28 TP_INT                           IN */
   +#define TOUCH_RESET_PIN         10 /*P0.10 TP_RESET                         OUT */
    
   -// Heartrate sensor i2c
   -#define HEARTRATE_DATA_PIN       6 //P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O
   -#define HEARTRATE_CLOCK_PIN      7 //P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT
   -#define HEARTRATE_INT_PIN       30 //P0.30 HRS3300-TEST                     IN
   +/* Heartrate sensor i2c */
   +#define HEARTRATE_DATA_PIN       6 /*P0.06 BMA421-SDA, HRS3300-SDA, TP-SDA  I/O */
   +#define HEARTRATE_CLOCK_PIN      7 /*P0.07 BMA421-SCL, HRS3300-SCL, TP-SCL  OUT */
   +#define HEARTRATE_INT_PIN       30 /*P0.30 HRS3300-TEST                     IN */
    
   -// apps/blinky support
   +/* apps/blinky support */
    #define LED_BLINK_PIN   LCD_BACKLIGHT_HIGH_PIN
    
    
   ```
   
   </details>
   
   #### hw/bsp/pinetime/src/sbrk.c
   <details>
   
   ```diff
   @@ -23,7 +23,8 @@
    static char *brk __attribute__ ((section (".data")));
    
    void
   -_sbrkInit(char *base, char *limit) {
   +_sbrkInit(char *base, char *limit)
   +{
        sbrkBase = base;
        sbrkLimit = limit;
        brk = base;
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399426955
 
 

 ##########
 File path: hw/bsp/pinetime/syscfg.yml
 ##########
 @@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Settings this BSP defines.
+syscfg.defs:
+
+# Settings this BSP overrides.
+syscfg.vals:
 
 Review comment:
   Any reasons for not having `CONFIG_FCB_FLASH_AREA`, `REBOOT_LOG_FLASH_AREA` and `COREDUMP_FLASH_AREA` set ?
   Also there are no timer configurations for BLE controller, is there a reason for that?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399668672
 
 

 ##########
 File path: hw/bsp/pinetime/pkg.yml
 ##########
 @@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "hw/bsp/pinetime"
+pkg.type: bsp
+pkg.description: "BSP definition for the Pine64 PineTime smartwatch"
+pkg.author: "Apache Mynewt <de...@mynewt.apache.org>"
+pkg.homepage: "http://mynewt.apache.org/"
+pkg.keywords:
+    - nrf52
+    - Pine64
+    - PineTime
+
+pkg.cflags:
+    - '-DNRF52'
+    # TODO: Move to more specific variable, however this currently causes a build failure '-DNRF52832_XXAA'
 
 Review comment:
   So the first build problem I get is in `hw/mcu/nordic/nrf52xxx/include/nrfx_config.h`. This seems easily solvable, however there are more assumptions in the code for `NRF52` to be defined. Most of the bsp use `-DNRF52`, so I suggest to leave the TODO as-is and fix this later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605439518
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-28 12:15:07)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 12 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/fa0029b85b0e978685cc5f754a5e01a52c6fa629/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399640633
 
 

 ##########
 File path: hw/bsp/pinetime/README.md
 ##########
 @@ -0,0 +1,56 @@
+<!--
+#
+#   Copyright 2020 Casper Meijn <ca...@meijn.net>
+#
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+#
+-->
+
+# mynewt bsp for PineTime
+
+## Overview
+
+This is a board support package for the Pine64 PineTime smartwatch. See [device wiki](https://wiki.pine64.org/index.php/PineTime) for documentation. See [store](https://store.pine64.org/?product=pinetime-dev-kit) for buying a dev kit.
+
+## Status
+
+Currently the status is: incomplete.
+
+Available drivers:
+
+- Only pin defenitions are available
+
+## Usage
+
+The bsp is configured to use openocd and a ST-LINK programmer. Connect your device to the ST-LINK and it to your computer. Then run the following commando to start make the LCD backlight blink:
+
+```bash
+newt new blinky-pinetime
+cd blinky-pinetime
+newt sync
+
+newt target create boot-pinetime
+newt target set boot-pinetime \
+    app=@mcuboot/boot/mynewt \
+    bsp=@apache-mynewt-core/hw/bsp/pinetime \
+    build_profile=optimized
+newt build boot-pinetime
+newt load boot-pinetime
+
+newt target create blinky-pinetime
+newt target set blinky-pinetime \
+    app=apps/blinky \
+    bsp=@apache-mynewt-core/hw/bsp/pinetime \
+    build_profile=debug
+newt run blinky-pinetime 0
+```
 
 Review comment:
   I am not a natural writer, but I like the idea of a blinky tutorial. The [nRF52](https://mynewt.apache.org/latest/tutorials/blinky/nRF52.html) tutorial helped me a lot, so I will try to create a page like that.
   
   However I would like to document the status of the BSP, as not drivers are available yet. Do you have ideas on how to do that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605525758
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605439557
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/pinetime/src/sbrk.c
   <details>
   
   ```diff
   @@ -23,7 +23,7 @@
    static char *brk __attribute__ ((section (".data")));
    
    void
   -_sbrkInit(char *base, char *limit) 
   +_sbrkInit(char *base, char *limit)
    {
        sbrkBase = base;
        sbrkLimit = limit;
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399641107
 
 

 ##########
 File path: hw/bsp/pinetime/syscfg.yml
 ##########
 @@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Settings this BSP defines.
+syscfg.defs:
+
+# Settings this BSP overrides.
+syscfg.vals:
 
 Review comment:
   No, I don't have a reason for that, other than that is was not in the [BSP porting tutorial](https://mynewt.apache.org/latest/os/core_os/porting/port_bsp.html). Do you have a good example of that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] caspermeijn commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
caspermeijn commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605619584
 
 
   I split the documentation into a seperate PR in the hope to make progress on the BSP while the docs are discussed https://github.com/apache/mynewt-core/pull/2254

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605525744
 
 
   
   <!-- license-bot -->
   
   ## RAT Report (2020-03-28 22:05:02)
   
   ## New files with unknown licenses
   
   * <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a>
   
   ## 13 new files were excluded from check (.rat-excludes)
   
   <details>
     <summary>Detailed analysis</summary>
   
   ## New files in this PR
   
   | License | File |
   |---------|------|
   | ?????  | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/boot-pinetime.ld">hw/bsp/pinetime/boot-pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/bsp.yml">hw/bsp/pinetime/bsp.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime.ld">hw/bsp/pinetime/pinetime.ld</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime_debug.sh">hw/bsp/pinetime/pinetime_debug.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pinetime_download.sh">hw/bsp/pinetime/pinetime_download.sh</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/pkg.yml">hw/bsp/pinetime/pkg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/syscfg.yml">hw/bsp/pinetime/syscfg.yml</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/include/bsp/bsp.h">hw/bsp/pinetime/include/bsp/bsp.h</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/src/hal_bsp.c">hw/bsp/pinetime/src/hal_bsp.c</a> |
   | AL     | <a href="https://github.com/apache/mynewt-core/blob/89c38058336a7662b54cb6fc7889893c7e096675/hw/bsp/pinetime/src/sbrk.c">hw/bsp/pinetime/src/sbrk.c</a> |
   </details>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#issuecomment-605467010
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399401108
 
 

 ##########
 File path: hw/bsp/pinetime/README.md
 ##########
 @@ -0,0 +1,56 @@
+<!--
+#
+#   Copyright 2020 Casper Meijn <ca...@meijn.net>
+#
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+#
+-->
+
+# mynewt bsp for PineTime
+
+## Overview
+
+This is a board support package for the Pine64 PineTime smartwatch. See [device wiki](https://wiki.pine64.org/index.php/PineTime) for documentation. See [store](https://store.pine64.org/?product=pinetime-dev-kit) for buying a dev kit.
+
+## Status
+
+Currently the status is: incomplete.
+
+Available drivers:
+
+- Only pin defenitions are available
+
+## Usage
+
+The bsp is configured to use openocd and a ST-LINK programmer. Connect your device to the ST-LINK and it to your computer. Then run the following commando to start make the LCD backlight blink:
+
+```bash
+newt new blinky-pinetime
+cd blinky-pinetime
+newt sync
+
+newt target create boot-pinetime
+newt target set boot-pinetime \
+    app=@mcuboot/boot/mynewt \
+    bsp=@apache-mynewt-core/hw/bsp/pinetime \
+    build_profile=optimized
+newt build boot-pinetime
+newt load boot-pinetime
+
+newt target create blinky-pinetime
+newt target set blinky-pinetime \
+    app=apps/blinky \
+    bsp=@apache-mynewt-core/hw/bsp/pinetime \
+    build_profile=debug
+newt run blinky-pinetime 0
+```
 
 Review comment:
   I haven't seen any other BSP featuring a `README` file. I believe this content would be useful in the documentation, perhaps a blinky-like tutorial.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz merged pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
mlaz merged pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

Posted by GitBox <gi...@apache.org>.
mlaz commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch
URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r399412434
 
 

 ##########
 File path: hw/bsp/pinetime/pkg.yml
 ##########
 @@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "hw/bsp/pinetime"
+pkg.type: bsp
+pkg.description: "BSP definition for the Pine64 PineTime smartwatch"
+pkg.author: "Apache Mynewt <de...@mynewt.apache.org>"
+pkg.homepage: "http://mynewt.apache.org/"
+pkg.keywords:
+    - nrf52
+    - Pine64
+    - PineTime
+
+pkg.cflags:
+    - '-DNRF52'
+    # TODO: Move to more specific variable, however this currently causes a build failure '-DNRF52832_XXAA'
 
 Review comment:
   I'm wondering which would be the build failure here. It looks like NRF52832_XXAA would be the right value.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services