[GitHub] [zeppelin] Reamer commented on a change in pull request #4199: [ZEPPELIN-5481] Support to run R interpreter in yarn mode with customized conda env

[GitBox <gi...@apache.org>]

Reamer commented on a change in pull request #4199:
URL: https://github.com/apache/zeppelin/pull/4199#discussion_r684964985



##########
File path: rlang/src/main/java/org/apache/zeppelin/r/IRInterpreter.java
##########
@@ -152,6 +153,17 @@ protected void initIRKernel() throws IOException, InterpreterException {
     }
   }
 
+  @Override
+  protected Map<String, String> setupKernelEnv() throws IOException {
+    Map<String, String> envs = super.setupKernelEnv();
+    String pathEnv = envs.getOrDefault("PATH", "");
+    if (condaEnv != null) {
+      pathEnv = new File(".").getAbsolutePath() + "/" + condaEnv + "/bin:" + pathEnv;

Review comment:
       Please use `File.separator` and `File.pathSeparator` to build the `PATH` environment variable.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org