[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1870: Cygwin Build Is Broken Again

[GitBox <gi...@apache.org>]

patacongo edited a comment on issue #1870:
URL: https://github.com/apache/incubator-nuttx/issues/1870#issuecomment-696825452


   With` make V=1` I can see this is in the archive target of Application.mk:
   
       ...
       make[3]: Leaving directory '/cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/system/readline'
       for app in /cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/builtin /cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/examples/hello /cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/nshlib /cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/platform /cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/system/nsh /cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/system/readline; do \
               make -C "${app}" archive ; \
       done
       make[3]: Entering directory '/cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/builtin'
       /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
       /bin/sh: -c: line 1: syntax error: unexpected end of file
       make[3]: *** [/cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/Application.mk:143: archive] Error 1
       make[3]: Leaving directory '/cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/builtin'   
       make[3]: Entering directory '/cygdrive/d/Spuda/Documents/projects/nuttx/master/apps/examples/hello'
       ...
   
   That suggests that one of these changes is the culprit that broke the build:
   
       18137c0fe (Matias N         2020-09-12 00:36:23 -0300 141) archive:
       d232823e6 (Xiang Xiao       2020-05-19 00:08:15 +0800 142) ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
       18137c0fe (Matias N         2020-09-12 00:36:23 -0300 143)      $(call ARCHIVE_ADD, "${shell cygpath -w $(BIN)}", $(OBJS))
       119f81f30 (David Sidrane    2020-02-21 08:22:26 -0800 144) else
       18137c0fe (Matias N         2020-09-12 00:36:23 -0300 145)      $(call ARCHIVE_ADD, $(BIN), $(OBJS))
       119f81f30 (David Sidrane    2020-02-21 08:22:26 -0800 146) endif
   
   @v01d 18137c0fe  is the only one that looks like a candidate for introducing the problem.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org