[jira] [Resolved] (AVRO-3044) Protocol Callback interface should have @AvroGenerated

["Ryan Skraba (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Skraba resolved AVRO-3044.
-------------------------------
    Resolution: Fixed

> Protocol Callback interface should have @AvroGenerated
> ------------------------------------------------------
>
>                 Key: AVRO-3044
>                 URL: https://issues.apache.org/jira/browse/AVRO-3044
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.10.1
>            Reporter: Anatoly Kupriyanov
>            Priority: Major
>             Fix For: 1.10.2
>
>
> This is very similar to AVRO-2298
> The protocol has interface
>  
> {{@org.apache.avro.specific.AvroGenerated}}
>  {{public interface SomeProto {}}
>  {{  public static final org.apache.avro.Protocol PROTOCOL = .....}}
> *{{// here it should also have @}}{{AvroGenerated}}*{{}}
>  {{  @SuppressWarnings("all")}}
>  {{  public interface Callback extends SomeProto {}}
>  {{  public static final org.apache.avro.Protocol PROTOCOL = com.my.SomeProto.PROTOCOL;}}
>  {
> {  }
> }}
>  {{}}}
>  
>  
> This is the place in the code: [https://github.com/apache/avro/blob/7d1e63b219e6d0778bc57195152477adee97fcab/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/protocol.vm#L64]
>  
> Also as I see the $protocol.getDoc() javadoc should not be between interface and annotations, it breaks javadoc processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)