[GitHub] [spark] maropu commented on a change in pull request #30047: [SPARK-33078][SQL] Add config for json expression optimization

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30047:
URL: https://github.com/apache/spark/pull/30047#discussion_r505263175



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##########
@@ -34,8 +35,10 @@ import org.apache.spark.sql.types.{ArrayType, StructType}
  *      contains all accessed fields in original CreateNamedStruct.
  */
 object OptimizeJsonExprs extends Rule[LogicalPlan] {
+  private def enabledJsonOptimization = SQLConf.get.jsonExpressionOptimization

Review comment:
       We need this variable? Could we inline this in L41?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org