You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/07/20 10:03:05 UTC

[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2741: ARTEMIS-2415 JDBCJournal miss pending tasks during shutdown

michaelpearce-gain commented on a change in pull request #2741: ARTEMIS-2415 JDBCJournal miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r305574983
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ##########
 @@ -268,6 +271,8 @@ private boolean internalStop(boolean ioCriticalError, boolean sendFailover) thro
             idGenerator.persistCurrentID();
       }
 
+      deletingLargeMessageTasks.await(30, TimeUnit.SECONDS);
 
 Review comment:
   -1 This isnt a good idea. On case of split brain with network pinger and network is detected split we need the isolated to shutdown to occur immediately without any blocking. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services