You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/11/29 08:58:48 UTC
[GitHub] [libcloud] micafer opened a new pull request #1630: Add Server Groups functions in OpenStack driver
micafer opened a new pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630
## Add Server Groups functions in OpenStack driver
### Description
Enable to list, get, create and delete server groups.
Also enable to set the server group in the create node function to enable affinity and anti-affinity policies.
#1629
### Status
Replace this: describe the PR status. Examples:
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630#issuecomment-981419756
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1630](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1efc66c) into [trunk](https://codecov.io/gh/apache/libcloud/commit/460876539f363b266cc4e01ab76598fa53b711a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4608765) will **decrease** coverage by `0.00%`.
> The diff coverage is `81.69%`.
[](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1630 +/- ##
==========================================
- Coverage 83.16% 83.16% -0.01%
==========================================
Files 397 397
Lines 86557 86627 +70
Branches 9198 9207 +9
==========================================
+ Hits 71989 72046 +57
- Misses 11441 11449 +8
- Partials 3127 3132 +5
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.17% <73.17%> (-0.39%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.53% <93.33%> (-0.02%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4608765...1efc66c](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630#issuecomment-981419756
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1630](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef727b2) into [trunk](https://codecov.io/gh/apache/libcloud/commit/460876539f363b266cc4e01ab76598fa53b711a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4608765) will **decrease** coverage by `0.00%`.
> The diff coverage is `81.69%`.
[](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1630 +/- ##
==========================================
- Coverage 83.16% 83.16% -0.01%
==========================================
Files 397 397
Lines 86557 86627 +70
Branches 9198 9207 +9
==========================================
+ Hits 71989 72046 +57
- Misses 11441 11449 +8
- Partials 3127 3132 +5
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.17% <73.17%> (-0.39%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.53% <93.33%> (-0.02%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4608765...ef727b2](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] micafer commented on pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
micafer commented on pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630#issuecomment-984433508
Hi @Kami,
Integration Tests are failing and the error seems that is not related with this PR.
Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on a change in pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630#discussion_r760404765
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -4813,3 +4910,47 @@ def __repr__(self):
' snapshots="%s", backups="%s">'
% (self.volumes, self.gigabytes, self.snapshots, self.backups)
)
+
+
+class OpenStack_2_ServerGroup(object):
+ """
+ Server Group info.
+
+ See:
+ https://docs.openstack.org/api-ref/compute/?expanded=create-server-detail,list-server-groups-detail#server-groups-os-server-groups
+ """
+
+ def __init__(
+ self,
+ id,
+ name,
+ policy,
+ members=[],
Review comment:
Should avoid mutable defaults here for ``members`` and ``rules``argument and default to ``None`` and set the value to empty list if it's not set inside the constructor (self.members = members or []``.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630#issuecomment-981419756
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1630](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0df3639) into [trunk](https://codecov.io/gh/apache/libcloud/commit/97a417d6c762c2cefc16d74c79243eba7db2721a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97a417d) will **decrease** coverage by `0.00%`.
> The diff coverage is `81.69%`.
[](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1630 +/- ##
==========================================
- Coverage 83.17% 83.17% -0.01%
==========================================
Files 398 398
Lines 86624 86694 +70
Branches 9204 9213 +9
==========================================
+ Hits 72053 72110 +57
- Misses 11442 11450 +8
- Partials 3129 3134 +5
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.17% <73.17%> (-0.39%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.53% <93.33%> (-0.02%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [97a417d...0df3639](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630#issuecomment-984980712
@micafer Not sure why those tests are failing. Could be a temporary issue since it works fine in other PRs (so re-run may help).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] micafer merged pull request #1630: Add Server Groups functions in OpenStack driver
Posted by GitBox <gi...@apache.org>.
micafer merged pull request #1630:
URL: https://github.com/apache/libcloud/pull/1630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org