You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marvin Froeder (JIRA)" <ji...@codehaus.org> on 2008/10/29 13:42:51 UTC
[jira] Created: (MRESOURCES-76) FilteringUtils escapeWindowsPath()
doesn't work on Windows
FilteringUtils escapeWindowsPath() doesn't work on Windows
----------------------------------------------------------
Key: MRESOURCES-76
URL: http://jira.codehaus.org/browse/MRESOURCES-76
Project: Maven 2.x Resources Plugin
Issue Type: Bug
Reporter: Marvin Froeder
Attachments: FilteringUtilsTest.java
The method escapeWindowsPath() is replacing colon by backslash + colon.
I.e.
D:\temp
is escaped as
D\:\\temp
But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
Even java.io.File is not able to handle that too. The attached test proves it.
I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MSHARED-78:
--------------------------------
Fix Version/s: maven-filtering-1.0
Component/s: maven-filtering
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0
>
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=181327#action_181327 ]
Benjamin Bentmann commented on MSHARED-78:
------------------------------------------
http://svn.apache.org/repos/asf/maven/shared/trunk/maven-filtering/
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MSHARED-78.
-------------------------------
Resolution: Fixed
fixed in rev [749459|http://svn.apache.org/viewvc?rev=749459&view=rev]
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160251#action_160251 ]
Olivier Lamy commented on MSHARED-78:
-------------------------------------
Sure this should be optionnal.
As it was introduced as a feature, IMHO this must enable by default and we must add a parameter to be able to disable this.
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=165958#action_165958 ]
Jason van Zyl commented on MSHARED-78:
--------------------------------------
The attached patch we've been using in Nexus for 3 months. Does anyone have a problem applying this?
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRESOURCES-76) FilteringUtils
escapeWindowsPath() doesn't work on Windows
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRESOURCES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=152333#action_152333 ]
Olivier Lamy commented on MRESOURCES-76:
----------------------------------------
So what how can we fix that ?
apply this only for files : *.properties ?
Not really sure.
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MRESOURCES-76
> URL: http://jira.codehaus.org/browse/MRESOURCES-76
> Project: Maven 2.x Resources Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Reporter: Marvin Froeder
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Paul Jackson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160248#action_160248 ]
Paul Jackson commented on MSHARED-78:
-------------------------------------
IMO, Filtering should not automatically add escape characters - it takes control away from a user. Better to never add escape characters and leave it to the user to add them as necessary.
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Casey Butterworth (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160884#action_160884 ]
Casey Butterworth commented on MSHARED-78:
------------------------------------------
Unless there's a workaround that I'm not aware of, this defect is effectively rendering the 2.3 resources plugin unusable for any projects that uses resource filtering to directory locations (e.g. basedir) on windows, which I imagine is a large number of projects. MRESOURCES-81 is a good description of the problem.
I've noticed that this is targeted at maven-filtering-1.0-beta-4, but i'm wondering if it should not be in the next release instead, and also be accompanied by a maven-release-plugin release?
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRESOURCES-76) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Marvin Froeder (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRESOURCES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Froeder updated MRESOURCES-76:
-------------------------------------
Affects Version/s: 2.3
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MRESOURCES-76
> URL: http://jira.codehaus.org/browse/MRESOURCES-76
> Project: Maven 2.x Resources Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Reporter: Marvin Froeder
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MSHARED-78:
--------------------------------
Fix Version/s: (was: maven-filtering-1.0-beta-3)
maven-filtering-1.0-beta-4
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Marvin Froeder (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Froeder updated MSHARED-78:
----------------------------------
Attachment: filtering.patch
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRESOURCES-76) FilteringUtils
escapeWindowsPath() doesn't work on Windows
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRESOURCES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=152314#action_152314 ]
Benjamin Bentmann commented on MRESOURCES-76:
---------------------------------------------
I believe the motivation for this escaping was the use case of filtering properties files, where backslash and colon have special meanings.
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MRESOURCES-76
> URL: http://jira.codehaus.org/browse/MRESOURCES-76
> Project: Maven 2.x Resources Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Reporter: Marvin Froeder
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Anton Makeev (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170311#action_170311 ]
Anton Makeev commented on MSHARED-78:
-------------------------------------
I reckon not only the windows paths should be escaped, but all the properties filtered.
For example, if I have a property defined as <myValue>xxx\yyy:zzz<myValue> it will be read from the *.properties file incorrectly as well.
Thanks,
Anton Makeev
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Moved: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy moved MRESOURCES-76 to MSHARED-78:
-----------------------------------------------
Affects Version/s: (was: 2.3)
maven-filtering-1.0-beta-2
Issue Type: Improvement (was: Bug)
Key: MSHARED-78 (was: MRESOURCES-76)
Project: Maven Shared Components (was: Maven 2.x Resources Plugin)
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Fix For: maven-filtering-1.0
>
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRESOURCES-76) FilteringUtils
escapeWindowsPath() doesn't work on Windows
Posted by "Marvin Froeder (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRESOURCES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=152316#action_152316 ]
Marvin Froeder commented on MRESOURCES-76:
------------------------------------------
I have XML and properties on my projects and it still working.
I have no idea how important is to escape colon, but if this is truly required should be done only at .properties files.
VELO
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MRESOURCES-76
> URL: http://jira.codehaus.org/browse/MRESOURCES-76
> Project: Maven 2.x Resources Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Reporter: Marvin Froeder
> Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath()
doesn't work on Windows
Posted by "Jayesh Lalwani (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=181326#action_181326 ]
Jayesh Lalwani commented on MSHARED-78:
---------------------------------------
Where can I get maven-filtering-1.0-beta-4? Is there a SVN that I can checkout the code from?
> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
> Key: MSHARED-78
> URL: http://jira.codehaus.org/browse/MSHARED-78
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0-beta-2
> Reporter: Marvin Froeder
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0-beta-4
>
> Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that. If you try to open D\:\\temp on explorer, will not work.
> Even java.io.File is not able to handle that too. The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira