You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/23 13:55:38 UTC

[GitHub] [pulsar] Shoothzj commented on pull request #11813: [ISSUE 11796] throw NPE when readEntry

Shoothzj commented on pull request #11813:
URL: https://github.com/apache/pulsar/pull/11813#issuecomment-925839252


   @lhotari code `managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java` the callback paas the ctx as null.
   But in class `PersistentDispatcherSingleActiveConsumer` `readEntryFailed` method acquire the ctx(Consumer) not be null.
   So the code should be
   
   `            opReadEntry.readEntriesFailed(new ManagedLedgerException.NoMoreEntriesToReadException("The ceilingKey(K key) method is used to return the " +
                       "least key greater than or equal to the given key, or null if there is no such key"), ctx);`
   
   Am i right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org