You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Clebert Suconic <cl...@gmail.com> on 2019/03/04 01:25:22 UTC

[VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
release. This is a second re-spin.

This is a sub component of ActiveMQ Artemis Native,

Source distribution can be found here:
https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/

Maven repository is here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1179


The source tag:
https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0



Notice this is a sub component of ActiveMQ Artemis, and the release
notes will be part of the main component. And also, the binary here is
distributed through maven.


[ ] +1 approve the release as Apache Artemis 2.4.0
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)


Here's my +1


--
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Robbie Gemmell <ro...@gmail.com>.
Yep the release itself is fine, just a matter of process around
development / website updates / future votes etc. Thanks Clebert.

Robbie

On Wed, 6 Mar 2019 at 14:06, Clebert Suconic <cl...@gmail.com> wrote:
>
> Fair enough.. I can do that..
>
> That does not invalidate the release.. I will create a 1.0.0 release,
> with a component, and there will be a release notes.
>
> On Wed, Mar 6, 2019 at 6:00 AM Robbie Gemmell <ro...@gmail.com> wrote:
> >
> > In reading this again, this bit doesnt really make sense to me:
> > "Notice this is a sub component of ActiveMQ Artemis, and the release
> > notes will be part of the main component."
> >
> > Since this will be a separately released component, and each release
> > will likely be used across a range of broker releases going forward,
> > it doesnt seem workable to combine its release notes with the broker
> > release notes. They are independent. It wouldnt be obvious later which
> > broker release contained notes for this components release or which of
> > those notes in that broker release actually apply to it, making it
> > difficult to see the changes in a given release such as this, or see
> > future changes needed before its next release is considered ready to
> > go, etc.
> >
> > Its possible to use the same ARTEMIS JIRA project but there should
> > still be a JIRA version (and probably component) for each release, e.g
> > artemis-native-1.0.0 this time. Looking at the commits list suggests
> > some candidate JIRAs/changes made since the 2.6.0 release that could
> > be release noted:
> > https://github.com/apache/activemq-artemis-native/commits/master
> >
> > Robbie
> >
> > On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com> wrote:
> > >
> > > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
> > > release. This is a second re-spin.
> > >
> > > This is a sub component of ActiveMQ Artemis Native,
> > >
> > > Source distribution can be found here:
> > > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/
> > >
> > > Maven repository is here:
> > > https://repository.apache.org/content/repositories/orgapacheactivemq-1179
> > >
> > >
> > > The source tag:
> > > https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0
> > >
> > >
> > >
> > > Notice this is a sub component of ActiveMQ Artemis, and the release
> > > notes will be part of the main component. And also, the binary here is
> > > distributed through maven.
> > >
> > >
> > > [ ] +1 approve the release as Apache Artemis 2.4.0
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > >
> > > Here's my +1
> > >
> > >
> > > --
> > > Clebert Suconic
>
>
>
> --
> Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Clebert Suconic <cl...@gmail.com>.
Fair enough.. I can do that..

That does not invalidate the release.. I will create a 1.0.0 release,
with a component, and there will be a release notes.

On Wed, Mar 6, 2019 at 6:00 AM Robbie Gemmell <ro...@gmail.com> wrote:
>
> In reading this again, this bit doesnt really make sense to me:
> "Notice this is a sub component of ActiveMQ Artemis, and the release
> notes will be part of the main component."
>
> Since this will be a separately released component, and each release
> will likely be used across a range of broker releases going forward,
> it doesnt seem workable to combine its release notes with the broker
> release notes. They are independent. It wouldnt be obvious later which
> broker release contained notes for this components release or which of
> those notes in that broker release actually apply to it, making it
> difficult to see the changes in a given release such as this, or see
> future changes needed before its next release is considered ready to
> go, etc.
>
> Its possible to use the same ARTEMIS JIRA project but there should
> still be a JIRA version (and probably component) for each release, e.g
> artemis-native-1.0.0 this time. Looking at the commits list suggests
> some candidate JIRAs/changes made since the 2.6.0 release that could
> be release noted:
> https://github.com/apache/activemq-artemis-native/commits/master
>
> Robbie
>
> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com> wrote:
> >
> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
> > release. This is a second re-spin.
> >
> > This is a sub component of ActiveMQ Artemis Native,
> >
> > Source distribution can be found here:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/
> >
> > Maven repository is here:
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1179
> >
> >
> > The source tag:
> > https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0
> >
> >
> >
> > Notice this is a sub component of ActiveMQ Artemis, and the release
> > notes will be part of the main component. And also, the binary here is
> > distributed through maven.
> >
> >
> > [ ] +1 approve the release as Apache Artemis 2.4.0
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> >
> > Here's my +1
> >
> >
> > --
> > Clebert Suconic



-- 
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Robbie Gemmell <ro...@gmail.com>.
In reading this again, this bit doesnt really make sense to me:
"Notice this is a sub component of ActiveMQ Artemis, and the release
notes will be part of the main component."

Since this will be a separately released component, and each release
will likely be used across a range of broker releases going forward,
it doesnt seem workable to combine its release notes with the broker
release notes. They are independent. It wouldnt be obvious later which
broker release contained notes for this components release or which of
those notes in that broker release actually apply to it, making it
difficult to see the changes in a given release such as this, or see
future changes needed before its next release is considered ready to
go, etc.

Its possible to use the same ARTEMIS JIRA project but there should
still be a JIRA version (and probably component) for each release, e.g
artemis-native-1.0.0 this time. Looking at the commits list suggests
some candidate JIRAs/changes made since the 2.6.0 release that could
be release noted:
https://github.com/apache/activemq-artemis-native/commits/master

Robbie

On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com> wrote:
>
> I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
> release. This is a second re-spin.
>
> This is a sub component of ActiveMQ Artemis Native,
>
> Source distribution can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/
>
> Maven repository is here:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1179
>
>
> The source tag:
> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0
>
>
>
> Notice this is a sub component of ActiveMQ Artemis, and the release
> notes will be part of the main component. And also, the binary here is
> distributed through maven.
>
>
> [ ] +1 approve the release as Apache Artemis 2.4.0
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1
>
>
> --
> Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Timothy Bish <ta...@gmail.com>.
On 3/3/19 8:25 PM, Clebert Suconic wrote:
> I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
> release. This is a second re-spin.
>
> This is a sub component of ActiveMQ Artemis Native,
>
> Source distribution can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/
>
> Maven repository is here:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1179
>
>
> The source tag:
> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0
>
>
>
> Notice this is a sub component of ActiveMQ Artemis, and the release
> notes will be part of the main component. And also, the binary here is
> distributed through maven.
>
>
> [ ] +1 approve the release as Apache Artemis 2.4.0
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1
>
>
> --
> Clebert Suconic
>
+1

-- 
Tim Bish


[RESULT] [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Clebert Suconic <cl...@gmail.com>.
The Vote release has passed with +7 Votes (5 Bindings, 2 non binding),
thanks for all who helped on he release.


Binding:

- Christopher Shannon
- Gary Tully
- Justin Bertram
- Michael Andre Pearce
- Tim Bish

Non Binding:

- Francesco Nigro
- Howad Gao (voted on the previous thread for RC1 but he meant on this one)

Special thanks to Robbie Gemmel who "did not vote" but his
contribution helped me shape RC2 and get it out.





On Wed, Mar 6, 2019 at 7:17 PM Robbie Gemmell <ro...@gmail.com> wrote:
>
> All seems well in terms of my previous RC1 skim and the small fixups made
> thereafter for RC2, but to be clear I haven't voted (due to not actually trying
> things out myself or looking any closer).
>
> Robbie
>
> On Wed, 6 Mar 2019, 23:17 Clebert Suconic, <cl...@gmail.com>
> wrote:
>
> > @Robbie Gemmel: I will close the vote tomorrow morning. I'm confused
> > if I have your +1 or not?
> >
> > On Wed, Mar 6, 2019 at 10:45 AM michael.andre.pearce
> > <mi...@me.com.invalid> wrote:
> > >
> > > +1 i was able to build this on centos, then build artemis based on
> > cleberts artemis branch thats in pr and successfully and run a few smoke
> > tests.I have checked licenses etc and do not spot anything untoward.Sent
> > from my Samsung Galaxy smartphone.
> > > -------- Original message --------From: Clebert Suconic <
> > clebert.suconic@gmail.com> Date: 06/03/2019  15:35  (GMT+00:00) To:
> > dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0
> > (RC2) Here you have the release notes:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12345143On
> > Wed, Mar 6, 2019 at 9:58 AM Clebert Suconic<cl...@gmail.com>
> > wrote:>> @Michael: On validating the release, I have updated the PR to
> > consume> the release repository.>>
> > https://github.com/apache/activemq-artemis/pull/2570>> Travis CI should
> > do the validation now, that the build is running.>>> You can also consume
> > the native by downloading the branch from the PR.> Everything related to
> > libaio should work as expected on the branch and> that will consume the
> > release bits.>>>> On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce> <
> > michael.andre.pearce@me.com.invalid> wrote:> >> > Without sounding silly.
> > How am i meant to check this?Currently its a lib but as we dont have the
> > activemq artemis bit removed in master and dependency on it i cannot build
> > artemis with it and check its behaviour.Do you have a branch in artemis
> > that we can use that builds based on the dependency?Sent from my Samsung
> > Galaxy smartphone.> > -------- Original message --------From: Justin
> > Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To:
> > dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0
> > (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <
> > gary.tully@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert
> > Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose
> > an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second
> > re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> >
> > Source distribution can be found here:> >>
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/>
> > >> > Maven repository is here:> >>
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1179>
> > >> >> > The source tag:> >>
> > https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0>
> > >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the
> > release> > notes will be part of the main component. And also, the binary
> > here is> > distributed through maven.> >> >> > [ ] +1 approve the release
> > as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and
> > reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>>>>> -->
> > Clebert Suconic-- Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
> >



-- 
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Robbie Gemmell <ro...@gmail.com>.
All seems well in terms of my previous RC1 skim and the small fixups made
thereafter for RC2, but to be clear I haven't voted (due to not actually trying
things out myself or looking any closer).

Robbie

On Wed, 6 Mar 2019, 23:17 Clebert Suconic, <cl...@gmail.com>
wrote:

> @Robbie Gemmel: I will close the vote tomorrow morning. I'm confused
> if I have your +1 or not?
>
> On Wed, Mar 6, 2019 at 10:45 AM michael.andre.pearce
> <mi...@me.com.invalid> wrote:
> >
> > +1 i was able to build this on centos, then build artemis based on
> cleberts artemis branch thats in pr and successfully and run a few smoke
> tests.I have checked licenses etc and do not spot anything untoward.Sent
> from my Samsung Galaxy smartphone.
> > -------- Original message --------From: Clebert Suconic <
> clebert.suconic@gmail.com> Date: 06/03/2019  15:35  (GMT+00:00) To:
> dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0
> (RC2) Here you have the release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12345143On
> Wed, Mar 6, 2019 at 9:58 AM Clebert Suconic<cl...@gmail.com>
> wrote:>> @Michael: On validating the release, I have updated the PR to
> consume> the release repository.>>
> https://github.com/apache/activemq-artemis/pull/2570>> Travis CI should
> do the validation now, that the build is running.>>> You can also consume
> the native by downloading the branch from the PR.> Everything related to
> libaio should work as expected on the branch and> that will consume the
> release bits.>>>> On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce> <
> michael.andre.pearce@me.com.invalid> wrote:> >> > Without sounding silly.
> How am i meant to check this?Currently its a lib but as we dont have the
> activemq artemis bit removed in master and dependency on it i cannot build
> artemis with it and check its behaviour.Do you have a branch in artemis
> that we can use that builds based on the dependency?Sent from my Samsung
> Galaxy smartphone.> > -------- Original message --------From: Justin
> Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To:
> dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0
> (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <
> gary.tully@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert
> Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose
> an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second
> re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> >
> Source distribution can be found here:> >>
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/>
> >> > Maven repository is here:> >>
> https://repository.apache.org/content/repositories/orgapacheactivemq-1179>
> >> >> > The source tag:> >>
> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0>
> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the
> release> > notes will be part of the main component. And also, the binary
> here is> > distributed through maven.> >> >> > [ ] +1 approve the release
> as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and
> reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>>>>> -->
> Clebert Suconic-- Clebert Suconic
>
>
>
> --
> Clebert Suconic
>

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Clebert Suconic <cl...@gmail.com>.
@Robbie Gemmel: I will close the vote tomorrow morning. I'm confused
if I have your +1 or not?

On Wed, Mar 6, 2019 at 10:45 AM michael.andre.pearce
<mi...@me.com.invalid> wrote:
>
> +1 i was able to build this on centos, then build artemis based on cleberts artemis branch thats in pr and successfully and run a few smoke tests.I have checked licenses etc and do not spot anything untoward.Sent from my Samsung Galaxy smartphone.
> -------- Original message --------From: Clebert Suconic <cl...@gmail.com> Date: 06/03/2019  15:35  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) Here you have the release notes:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12345143On Wed, Mar 6, 2019 at 9:58 AM Clebert Suconic<cl...@gmail.com> wrote:>> @Michael: On validating the release, I have updated the PR to consume> the release repository.>> https://github.com/apache/activemq-artemis/pull/2570>> Travis CI should do the validation now, that the build is running.>>> You can also consume the native by downloading the branch from the PR.> Everything related to libaio should work as expected on the branch and> that will consume the release bits.>>>> On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce> <mi...@me.com.invalid> wrote:> >> > Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.> > -------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>>>>> --> Clebert Suconic-- Clebert Suconic



-- 
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by "michael.andre.pearce" <mi...@me.com.INVALID>.
+1 i was able to build this on centos, then build artemis based on cleberts artemis branch thats in pr and successfully and run a few smoke tests.I have checked licenses etc and do not spot anything untoward.Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: Clebert Suconic <cl...@gmail.com> Date: 06/03/2019  15:35  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) Here you have the release notes:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12345143On Wed, Mar 6, 2019 at 9:58 AM Clebert Suconic<cl...@gmail.com> wrote:>> @Michael: On validating the release, I have updated the PR to consume> the release repository.>> https://github.com/apache/activemq-artemis/pull/2570>> Travis CI should do the validation now, that the build is running.>>> You can also consume the native by downloading the branch from the PR.> Everything related to libaio should work as expected on the branch and> that will consume the release bits.>>>> On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce> <mi...@me.com.invalid> wrote:> >> > Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.> > -------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>>>>> --> Clebert Suconic-- Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Clebert Suconic <cl...@gmail.com>.
Here you have the release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12345143

On Wed, Mar 6, 2019 at 9:58 AM Clebert Suconic
<cl...@gmail.com> wrote:
>
> @Michael: On validating the release, I have updated the PR to consume
> the release repository.
>
> https://github.com/apache/activemq-artemis/pull/2570
>
> Travis CI should do the validation now, that the build is running.
>
>
> You can also consume the native by downloading the branch from the PR.
> Everything related to libaio should work as expected on the branch and
> that will consume the release bits.
>
>
>
> On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce
> <mi...@me.com.invalid> wrote:
> >
> > Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.
> > -------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>
>
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Clebert Suconic <cl...@gmail.com>.
@Michael: On validating the release, I have updated the PR to consume
the release repository.

https://github.com/apache/activemq-artemis/pull/2570

Travis CI should do the validation now, that the build is running.


You can also consume the native by downloading the branch from the PR.
Everything related to libaio should work as expected on the branch and
that will consume the release bits.



On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce
<mi...@me.com.invalid> wrote:
>
> Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.
> -------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>



--
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Clebert Suconic <cl...@gmail.com>.
It is more important to make sure the release has appropriate LICENSE
files, and any other requirements Apache License rules include on
releases...  (e.g. signatures on the maven repository).

There is a pending PR here for these changes as soon as the native
bits is released, if you really want to test the changes. (I already
tested it though, and it's fine).

https://github.com/apache/activemq-artemis/pull/2570

On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce
<mi...@me.com.invalid> wrote:
>
> Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.
> -------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>



-- 
Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Robbie Gemmell <ro...@gmail.com>.
That doesnt sound silly at all. Excellent question, well asked. Trying
things out is useful when voting to release it :)

On Tue, 5 Mar 2019 at 17:55, michael.andre.pearce
<mi...@me.com.invalid> wrote:
>
> Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.
> -------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by "michael.andre.pearce" <mi...@me.com.INVALID>.
Without sounding silly. How am i meant to check this?Currently its a lib but as we dont have the activemq artemis bit removed in master and dependency on it i cannot build artemis with it and check its behaviour.Do you have a branch in artemis that we can use that builds based on the dependency?Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: Justin Bertram <jb...@apache.org> Date: 05/03/2019  16:57  (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>> wrote:> >> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > Source distribution can be found here:> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> >> > Maven repository is here:> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1179> >> >> > The source tag:> >> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the release> > notes will be part of the main component. And also, the binary here is> > distributed through maven.> >> >> > [ ] +1 approve the release as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Justin Bertram <jb...@apache.org>.
LGTM

+1


Justin

On Tue, Mar 5, 2019 at 10:52 AM Gary Tully <ga...@gmail.com> wrote:

> +1
>
> On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com>
> wrote:
> >
> > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
> > release. This is a second re-spin.
> >
> > This is a sub component of ActiveMQ Artemis Native,
> >
> > Source distribution can be found here:
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/
> >
> > Maven repository is here:
> >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1179
> >
> >
> > The source tag:
> >
> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0
> >
> >
> >
> > Notice this is a sub component of ActiveMQ Artemis, and the release
> > notes will be part of the main component. And also, the binary here is
> > distributed through maven.
> >
> >
> > [ ] +1 approve the release as Apache Artemis 2.4.0
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> >
> > Here's my +1
> >
> >
> > --
> > Clebert Suconic
>

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Gary Tully <ga...@gmail.com>.
+1

On Mon, 4 Mar 2019 at 01:25, Clebert Suconic <cl...@gmail.com> wrote:
>
> I would like to propose an Apache ActiveMQ Artemis Native 1.0.0
> release. This is a second re-spin.
>
> This is a sub component of ActiveMQ Artemis Native,
>
> Source distribution can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/
>
> Maven repository is here:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1179
>
>
> The source tag:
> https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0
>
>
>
> Notice this is a sub component of ActiveMQ Artemis, and the release
> notes will be part of the main component. And also, the binary here is
> distributed through maven.
>
>
> [ ] +1 approve the release as Apache Artemis 2.4.0
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1
>
>
> --
> Clebert Suconic

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by Christopher Shannon <ch...@gmail.com>.
+1

On Mon, Mar 4, 2019 at 9:33 AM nigro_franz <ni...@gmail.com> wrote:

> +1 (non-binding)
>
>
>
> --
> Sent from:
> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>

Re: [VOTE] ActiveMQ Artemis Native 1.0.0 (RC2)

Posted by nigro_franz <ni...@gmail.com>.
+1 (non-binding)



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html