You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp> on 2005/02/25 07:26:25 UTC

[PATCH] refactoring of a message for localizability

Hi,

This patch refactor a message at subversion/libsvn_repos/dump.c
because the current message can be only partly localized.
With this patch, translators can translate two whole messages correctly.

Thanks,

- nori

Log:
Refactor a message output in executing 'svnadmin dump' for
localizability because the old message can be only partly translated.
Now translators can translate two whole messages correctly.

* subversion/libsvn_repos/dump.c
  (svn_repos_dump_fs2): Divide a message with a conditional expression
    to two complete messages.


Index: subversion/libsvn_repos/dump.c
===================================================================
--- subversion/libsvn_repos/dump.c	(revision 13145)
+++ subversion/libsvn_repos/dump.c	(working copy)
@@ -1041,8 +1041,10 @@
 
     loop_end:
       SVN_ERR (svn_stream_printf (feedback_stream, pool,
-                                  _("* %s revision %ld.\n"),
-                                  dumping ? "Dumped" : "Verified", to_rev));
+                                  dumping
+                                  ? _("* Dumped revision %ld.\n")
+                                  : _("* Verified revision %ld.\n"),
+                                  to_rev));
     }
 
   svn_pool_destroy (subpool);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] refactoring of a message for localizability

Posted by Greg Hudson <gh...@MIT.EDU>.
I'm Greg Hudson, and I approve this patch.

On Fri, 2005-02-25 at 02:26, Kobayashi Noritada wrote:
> -                                  _("* %s revision %ld.\n"),
> -                                  dumping ? "Dumped" : "Verified", to_rev));
> +                                  dumping
> +                                  ? _("* Dumped revision %ld.\n")
> +                                  : _("* Verified revision %ld.\n"),
> +                                  to_rev));


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org