You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/06 04:23:15 UTC

[GitHub] [incubator-kvrocks] Hexiaoqiao opened a new pull request, #551: Update repository link to Apache Incubator repo.

Hexiaoqiao opened a new pull request, #551:
URL: https://github.com/apache/incubator-kvrocks/pull/551

   Update repository link from kvrockslabs/kvrocks to apache/incubator-kvrocks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] Hexiaoqiao merged pull request #551: Update repository link to Apache Incubator repo.

Posted by GitBox <gi...@apache.org>.
Hexiaoqiao merged PR #551:
URL: https://github.com/apache/incubator-kvrocks/pull/551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #551: Update repository link to Apache Incubator repo.

Posted by GitBox <gi...@apache.org>.
git-hulk commented on code in PR #551:
URL: https://github.com/apache/incubator-kvrocks/pull/551#discussion_r866485385


##########
README.md:
##########
@@ -1,6 +1,6 @@
 <img src="docs/images/kvrocks_logo.png" alt="kvrocks_logo" width="350"/>
 
-# ![image](https://github.com/kvrockslabs/kvrocks/workflows/kvrocks%20ci%20actions/badge.svg) ![image](https://img.shields.io/badge/build-passing-brightgreen) [![GitHub license](https://img.shields.io/github/license/kvrockslabs/kvrocks)](https://github.com/kvrockslabs/kvrocks/blob/unstable/LICENSE) [![GitHub stars](https://img.shields.io/github/stars/kvrockslabs/kvrocks)](https://github.com/kvrockslabs/kvrocks/stargazers)
+# ![image](https://https://github.com/apache/incubator-kvrocks/workflows/kvrocks%20ci%20actions/badge.svg) ![image](https://img.shields.io/badge/build-passing-brightgreen) [![GitHub license](https://img.shields.io/github/license/apache/incubator-kvrocks)](https://github.com/apache/incubator-kvrocks/blob/unstable/LICENSE) [![GitHub stars](https://img.shields.io/github/stars/apache/incubator-kvrocks)](https://github.com/apache/incubator-kvrocks/stargazers)

Review Comment:
   ```suggestion
   # ![image](https://github.com/apache/incubator-kvrocks/workflows/kvrocks%20ci%20actions/badge.svg) ![image](https://img.shields.io/badge/build-passing-brightgreen) [![GitHub license](https://img.shields.io/github/license/apache/incubator-kvrocks)](https://github.com/apache/incubator-kvrocks/blob/unstable/LICENSE) [![GitHub stars](https://img.shields.io/github/stars/apache/incubator-kvrocks)](https://github.com/apache/incubator-kvrocks/stargazers)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] Hexiaoqiao commented on pull request #551: Update repository link to Apache Incubator repo.

Posted by GitBox <gi...@apache.org>.
Hexiaoqiao commented on PR #551:
URL: https://github.com/apache/incubator-kvrocks/pull/551#issuecomment-1119270147

   @git-hulk Thanks for your review. And sorry to overwrite your update since I followed mail list only but not take care the latest commit. Anyway the latest commit fix issue mentioned above. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] Hexiaoqiao commented on pull request #551: Update repository link to Apache Incubator repo.

Posted by GitBox <gi...@apache.org>.
Hexiaoqiao commented on PR #551:
URL: https://github.com/apache/incubator-kvrocks/pull/551#issuecomment-1119307626

   Committed to dev branch. Thanks @git-hulk @tisonkun for your reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org