You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/05/25 23:37:12 UTC
[PR] test(amber): DB-backed unit tests for ExecutionsMetadataPersistService and updateWorkflowState [texera]
Yicong-Huang opened a new pull request, #5213:
URL: https://github.com/apache/texera/pull/5213
### What changes were proposed in this PR?
Adds `ExecutionsMetadataPersistServiceSpec`, a `MockTexeraDB`-backed unit spec covering the three methods on `ExecutionsMetadataPersistService` plus the `ExecutionStateStore.updateWorkflowState` wrapper that sits on top of `tryUpdateExistingExecution`. The MockTexeraDB trait (already used by `WorkflowExecutionsResourceSpec` and peers) spins up an EmbeddedPostgres in `beforeAll`, loads `sql/texera_ddl.sql`, and tears down in `afterAll`.
Two latent silent-failure patterns are pinned with explanatory comments and filed as follow-up bugs: `tryGetExistingExecution` returns `Some(null)` instead of `None` for unknown eids, and `insertNewExecution` propagates a NOT NULL violation when `uid=None` despite the `Option[Integer]` signature. The pinned `Some(null)` test is paired with an `intercept[TestFailedException]`-based xfail-strict test asserting the intended `None` contract — it flips red the day the bug is fixed.
### Any related issues, documentation, discussions?
Closes #5210. Surfaces #5211 and #5212.
### How was this PR tested?
Added unit tests under `amber/src/test/scala/org/apache/texera/web/service/`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): DB-backed unit tests for ExecutionsMetadataPersistService and updateWorkflowState [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5213:
URL: https://github.com/apache/texera/pull/5213#issuecomment-4538135706
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5213?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.42%. Comparing base ([`9b850e2`](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9bec8c1`](https://app.codecov.io/gh/apache/texera/commit/9bec8c1210f054136d7a8c862d91d288f74ae27d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5213 +/- ##
============================================
+ Coverage 48.05% 48.42% +0.36%
+ Complexity 2348 2345 -3
============================================
Files 1042 1042
Lines 39973 39973
Branches 4251 4251
============================================
+ Hits 19211 19355 +144
+ Misses 19624 19473 -151
- Partials 1138 1145 +7
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.31% <ø> (+0.94%)` | :arrow_up: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.02% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.50% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (ø)` | | Carriedforward from [9b850e2](https://app.codecov.io/gh/apache/texera/commit/9b850e2ed8927a28cf4842d8534d4cb3f0ab01b7?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5213?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): DB-backed unit tests for ExecutionsMetadataPersistService and updateWorkflowState [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 merged PR #5213:
URL: https://github.com/apache/texera/pull/5213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org