You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/22 12:51:09 UTC

[GitHub] [shardingsphere] jacksparrow414 opened a new pull request #7892: refactor CuratorZookeeperRepository

jacksparrow414 opened a new pull request #7892:
URL: https://github.com/apache/shardingsphere/pull/7892


   Fixes #7883 .
   
   Changes proposed in this pull request:
   - Replace com.google.common.base.Charsets with java.nio.charset.StandardCharsets in CuratorZookeeperRepository.java
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #7892: refactor CuratorZookeeperRepository

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #7892:
URL: https://github.com/apache/shardingsphere/pull/7892


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7892: refactor CuratorZookeeperRepository

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7892:
URL: https://github.com/apache/shardingsphere/pull/7892#issuecomment-714523365


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=h1) Report
   > Merging [#7892](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/83eb27fa7d51e82857c3fbce8da6e5e274989555?el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7892/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7892      +/-   ##
   ============================================
   + Coverage     74.69%   74.76%   +0.06%     
   - Complexity      537      552      +15     
   ============================================
     Files          1449     1503      +54     
     Lines         22739    26269    +3530     
     Branches       4063     4884     +821     
   ============================================
   + Hits          16986    19639    +2653     
   - Misses         4658     5305     +647     
   - Partials       1095     1325     +230     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pository/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ292ZXJuYW5jZS9yZXBvc2l0b3J5L3pvb2tlZXBlci9DdXJhdG9yWm9va2VlcGVyUmVwb3NpdG9yeS5qYXZh) | `73.72% <66.66%> (ø)` | `26.00 <1.00> (ø)` | |
   | [...here/sql/parser/engine/ast/ASTSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvYXN0L0FTVFNRTFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ne/statement/standard/StandardSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvc3RhdGVtZW50L3N0YW5kYXJkL1N0YW5kYXJkU1FMUGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...itor/statement/impl/OracleStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.93% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
   | [...sql/visitor/format/impl/MySQLFormatSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9pbXBsL015U1FMRm9ybWF0U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...tatement/impl/SQLServerDALStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvU1FMU2VydmVyREFMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [.../visitor/format/impl/MySQLDALFormatSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9pbXBsL015U1FMREFMRm9ybWF0U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...r/statement/impl/OracleDMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `85.29% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...sql/visitor/PostgreSQLSQLVisitorFacadeFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9Qb3N0Z3JlU1FMU1FMVmlzaXRvckZhY2FkZUZhY3RvcnkuamF2YQ==) | `66.66% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
   | [...or/statement/impl/SQL92TCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyVENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [47 more](https://codecov.io/gh/apache/shardingsphere/pull/7892/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=footer). Last update [83eb27f...9108a8b](https://codecov.io/gh/apache/shardingsphere/pull/7892?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org