You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by pa...@apache.org on 2007/01/11 03:55:38 UTC

svn commit: r495096 - in /myfaces: core/trunk/impl/src/main/tld/entities/standard_select_many_checkbox_attributes.xml shared/trunk/core/src/main/java/org/apache/myfaces/shared/taglib/html/HtmlSelectManyCheckboxTagBase.java

Author: paulsp
Date: Wed Jan 10 18:55:38 2007
New Revision: 495096

URL: http://svn.apache.org/viewvc?view=rev&rev=495096
Log:
MYFACES-1519 - Add border attribute to <h:selectManyCheckbox>

Modified:
    myfaces/core/trunk/impl/src/main/tld/entities/standard_select_many_checkbox_attributes.xml
    myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/taglib/html/HtmlSelectManyCheckboxTagBase.java

Modified: myfaces/core/trunk/impl/src/main/tld/entities/standard_select_many_checkbox_attributes.xml
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/tld/entities/standard_select_many_checkbox_attributes.xml?view=diff&rev=495096&r1=495095&r2=495096
==============================================================================
--- myfaces/core/trunk/impl/src/main/tld/entities/standard_select_many_checkbox_attributes.xml (original)
+++ myfaces/core/trunk/impl/src/main/tld/entities/standard_select_many_checkbox_attributes.xml Wed Jan 10 18:55:38 2007
@@ -1,5 +1,6 @@
 <!-- all standard attributes of the selectManyCheckbox tag -->
 &ui_select_many_attributes;
+&html_border_attribute;
 &html_universal_attributes;
 &html_event_handler_attributes;
 &html_input_checkbox_attributes;

Modified: myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/taglib/html/HtmlSelectManyCheckboxTagBase.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/taglib/html/HtmlSelectManyCheckboxTagBase.java?view=diff&rev=495096&r1=495095&r2=495096
==============================================================================
--- myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/taglib/html/HtmlSelectManyCheckboxTagBase.java (original)
+++ myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/taglib/html/HtmlSelectManyCheckboxTagBase.java Wed Jan 10 18:55:38 2007
@@ -64,11 +64,7 @@
     private String _disabledClass;
     private String _enabledClass;
     private String _layout;
-
-    //FIXME: here there is no border element, in the others
-    // (HTMLSelectOneMenuTag, HtmlSelectOneRadioTag)
-    //  there is... inconsistent...
-    //private String _border;
+    private String _border;
 
 
     public void release() {
@@ -89,6 +85,7 @@
         _disabledClass=null;
         _enabledClass=null;
         _layout=null;
+        _border=null;
     }
 
     protected void setProperties(UIComponent component)
@@ -112,6 +109,7 @@
         setStringProperty(component, org.apache.myfaces.shared.renderkit.JSFAttr.DISABLED_CLASS_ATTR, _disabledClass);
         setStringProperty(component, org.apache.myfaces.shared.renderkit.JSFAttr.ENABLED_CLASS_ATTR, _enabledClass);
         setStringProperty(component, org.apache.myfaces.shared.renderkit.JSFAttr.LAYOUT_ATTR, _layout);
+        setIntegerProperty(component, HTML.BORDER_ATTR, _border);
    }
 
     public void setAccesskey(String accesskey)
@@ -192,5 +190,10 @@
     public void setLayout(String layout)
     {
         _layout = layout;
+    }
+
+    public void setBorder(String border)
+    {
+        _border = border;
     }
 }