You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/08 20:37:47 UTC

[GitHub] [airflow-site] kaxil opened a new pull request #3: [AIRFLOW-5148] Add Google Analytics to the Airflow doc website

kaxil opened a new pull request #3: [AIRFLOW-5148] Add Google Analytics to the Airflow doc website
URL: https://github.com/apache/airflow-site/pull/3
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5148
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Asked by @aijamalnk 
   
   Note from her:
   
   > I've looked at Google Analytics for the Airflow site, and I noticed that:
   > -The https://airflow.readthedocs.io/en/latest/ site has the GA code set up.
   > - The https://airflow.apache.org site does NOT have the GA code set up.
   > So the data that we're getting on GA is not complete. 
   > It would be really helpful to fix it soon, before we start revamping the website to understand the changes user behavior (I am signing a contract with a vendor next week)
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services