You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 10:13:44 UTC

[GitHub] [arrow] tustvold opened a new pull request, #13879: Update rust feature support docs

tustvold opened a new pull request, #13879:
URL: https://github.com/apache/arrow/pull/13879

   The feature support matrix for Rust is about a year out of date, lets update it :smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] tustvold commented on pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #13879:
URL: https://github.com/apache/arrow/pull/13879#issuecomment-1214882159

   > I couldn't figure out where the docs were defined
   
   I used the "Edit this page" button in the top right to work out where it was 
   ![image](https://user-images.githubusercontent.com/1781103/184623007-69969bf8-109e-49ba-8d16-39e7f9f90baa.png)
   
   > I can go figure out the correct invocation and do so for this PR if you would like
   
   That would be amazing, thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] tustvold commented on a diff in pull request #13879: Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #13879:
URL: https://github.com/apache/arrow/pull/13879#discussion_r945592065


##########
docs/source/status.rst:
##########
@@ -94,7 +94,7 @@ Data Types
 +===================+=======+=======+=======+============+=======+=======+=======+
 | Dictionary        | ✓     | ✓ (1) | ✓     | ✓ (1)      | ✓ (1) | ✓ (1) | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Extension         | ✓     | ✓     | ✓     |            |       |       | ✓     |
+| Extension         | ✓     | ✓     | ✓     |            |       | ✓     | ✓     |

Review Comment:
   Not sure about this one, but we support propagating the metadata which seems to be all that is required??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13879:
URL: https://github.com/apache/arrow/pull/13879#issuecomment-1215168093

   Benchmark runs are scheduled for baseline = bc1a16cd0eceeffe67893a7e8000d2dd28dcf3f1 and contender = a270afc946398a0279b1971a315858d8b5f07e2d. a270afc946398a0279b1971a315858d8b5f07e2d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/86b8c23aef3c4067be17303b78e31067...4883232e8f4648059c7d939f52c00885/)
   [Failed :arrow_down:0.14% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2e8d94978a4543edaf903bb239ea07bb...bb22d1f7d8df40598f37e2760bdec4be/)
   [Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1795fb0eb0b24848a356a1dac8c17bdc...d1a9add1ab8e4e15b7ed87ef902942f2/)
   [Finished :arrow_down:0.18% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0b93c3200c374e1192227ff5598f6832...5c3ba37f761f4ac89555bbcc84d8a209/)
   Buildkite builds:
   [Finished] [`a270afc9` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1308)
   [Failed] [`a270afc9` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1324)
   [Failed] [`a270afc9` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1306)
   [Finished] [`a270afc9` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1323)
   [Finished] [`bc1a16cd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1307)
   [Failed] [`bc1a16cd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1323)
   [Failed] [`bc1a16cd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1305)
   [Finished] [`bc1a16cd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1322)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13879:
URL: https://github.com/apache/arrow/pull/13879#issuecomment-1215168676

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1795fb0eb0b24848a356a1dac8c17bdc...d1a9add1ab8e4e15b7ed87ef902942f2/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13879: Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13879:
URL: https://github.com/apache/arrow/pull/13879#issuecomment-1214853799

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13879:
URL: https://github.com/apache/arrow/pull/13879#issuecomment-1215006680

   ```shell
   (arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ ./dev/merge_arrow_pr.sh 13879
   ARROW_HOME = /Users/alamb/Software/arrow/dev
   PROJECT_NAME = arrow
   
   === Pull Request #13879 ===
   title	MINOR: [Rust][Docs] Update rust feature support docs
   source	tustvold/update-rust-feature-support
   target	master
   url	https://api.github.com/repos/apache/arrow/pulls/13879
   Minor PR.  Please ensure it meets guidelines for minor.
   
   
   Proceed with merging pull request #13879? (y/n): y
   Author 1: Raphael Taylor-Davies <r....@googlemail.com>
   Pull request #13879 merged!
   Merge hash: a270afc946398a0279b1971a315858d8b5f07e2d
   Minor PR.  No JIRA issue to update.
   
   (arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] tustvold commented on a diff in pull request #13879: Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #13879:
URL: https://github.com/apache/arrow/pull/13879#discussion_r945591789


##########
docs/source/status.rst:
##########
@@ -81,11 +81,11 @@ Data Types
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
 | Struct            | ✓     | ✓     | ✓     | ✓          |  ✓    |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Map               | ✓     | ✓     | ✓     | ✓          |       |       | ✓     |
+| Map               | ✓     | ✓     | ✓     | ✓          |       |  ✓    | ✓     |

Review Comment:
   https://docs.rs/arrow/latest/arrow/array/struct.MapArray.html



##########
docs/source/status.rst:
##########
@@ -81,11 +81,11 @@ Data Types
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
 | Struct            | ✓     | ✓     | ✓     | ✓          |  ✓    |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Map               | ✓     | ✓     | ✓     | ✓          |       |       | ✓     |
+| Map               | ✓     | ✓     | ✓     | ✓          |       |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Dense Union       | ✓     | ✓     | ✓     |            |       |       | ✓     |
+| Dense Union       | ✓     | ✓     | ✓     |            |       |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Sparse Union      | ✓     | ✓     | ✓     |            |       |       | ✓     |
+| Sparse Union      | ✓     | ✓     | ✓     |            |       |  ✓    | ✓     |

Review Comment:
   https://docs.rs/arrow/latest/arrow/array/struct.UnionArray.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a diff in pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #13879:
URL: https://github.com/apache/arrow/pull/13879#discussion_r945611310


##########
docs/source/status.rst:
##########
@@ -128,7 +128,7 @@ IPC Format
 +-----------------------------+-------+-------+-------+------------+-------+-------+-------+
 | Sparse tensors              | ✓     |       |       |            |       |       |       |
 +-----------------------------+-------+-------+-------+------------+-------+-------+-------+
-| Buffer compression          | ✓     | ✓ (3) | ✓     |            |       |       | ✓     |
+| Buffer compression          | ✓     | ✓ (3) | ✓     |            |       |  ✓    | ✓     |

Review Comment:
   🎉 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb merged pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
alamb merged PR #13879:
URL: https://github.com/apache/arrow/pull/13879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] tustvold commented on a diff in pull request #13879: MINOR: [Rust][Docs] Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #13879:
URL: https://github.com/apache/arrow/pull/13879#discussion_r945594968


##########
docs/source/status.rst:
##########
@@ -40,13 +40,13 @@ Data Types
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
 | UInt8/16/32/64    | ✓     | ✓     | ✓     | ✓          |  ✓    |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Float16           |       |       | ✓     |            |       |       | ✓     |
+| Float16           |       |       | ✓     |            |       |  ✓    | ✓     |

Review Comment:
   https://docs.rs/arrow/latest/arrow/array/type.Float16Array.html



##########
docs/source/status.rst:
##########
@@ -40,13 +40,13 @@ Data Types
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
 | UInt8/16/32/64    | ✓     | ✓     | ✓     | ✓          |  ✓    |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Float16           |       |       | ✓     |            |       |       | ✓     |
+| Float16           |       |       | ✓     |            |       |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
 | Float32/64        | ✓     | ✓     | ✓     | ✓          |  ✓    |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
 | Decimal128        | ✓     | ✓     | ✓     |            |  ✓    |  ✓    | ✓     |
 +-------------------+-------+-------+-------+------------+-------+-------+-------+
-| Decimal256        | ✓     | ✓     | ✓     |            |  ✓    |       | ✓     |
+| Decimal256        | ✓     | ✓     | ✓     |            |  ✓    |  ✓    | ✓     |

Review Comment:
   https://docs.rs/arrow/latest/arrow/array/struct.Decimal256Array.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] tustvold commented on a diff in pull request #13879: Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #13879:
URL: https://github.com/apache/arrow/pull/13879#discussion_r945593329


##########
docs/source/status.rst:
##########
@@ -156,11 +156,11 @@ Flight RPC
 +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+
 | Flight RPC Transport                       | C++   | Java  | Go    | JavaScript | C#    | Rust  | Julia |
 +============================================+=======+=======+=======+============+=======+=======+=======+
-| gRPC_ transport (grpc:, grpc+tcp:)         | ✓     | ✓     | ✓     |            | ✓     |       |       |
+| gRPC_ transport (grpc:, grpc+tcp:)         | ✓     | ✓     | ✓     |            | ✓     | ✓     |       |
 +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+
-| gRPC domain socket transport (grpc+unix:)  | ✓     | ✓     | ✓     |            | ✓     |       |       |
+| gRPC domain socket transport (grpc+unix:)  | ✓     | ✓     | ✓     |            | ✓     | ✓     |       |
 +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+
-| gRPC + TLS transport (grpc+tls:)           | ✓     | ✓     | ✓     |            | ✓     |       |       |
+| gRPC + TLS transport (grpc+tls:)           | ✓     | ✓     | ✓     |            | ✓     | ✓     |       |

Review Comment:
   Arrow-flight uses tonic which supports [uds](https://github.com/hyperium/tonic/tree/master/examples/src/uds) and [tls](https://github.com/hyperium/tonic/tree/master/examples/src/tls)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] tustvold commented on a diff in pull request #13879: Update rust feature support docs

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #13879:
URL: https://github.com/apache/arrow/pull/13879#discussion_r945592463


##########
docs/source/status.rst:
##########
@@ -128,7 +128,7 @@ IPC Format
 +-----------------------------+-------+-------+-------+------------+-------+-------+-------+
 | Sparse tensors              | ✓     |       |       |            |       |       |       |
 +-----------------------------+-------+-------+-------+------------+-------+-------+-------+
-| Buffer compression          | ✓     | ✓ (3) | ✓     |            |       |       | ✓     |
+| Buffer compression          | ✓     | ✓ (3) | ✓     |            |       |  ✓    | ✓     |

Review Comment:
   This was just added by @liukun4515 and @alamb in https://github.com/apache/arrow-rs/pull/2369



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org